[$250] Group chat - Blank name in "This chat is with " when creating group chat with yourself

@parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to FAB > Start chat.
Click Add to group next to any user.
Click Next.
Unselect the user on the confirmation page.
Click Start group.

Expected Result:

The copy at the beginning of the conversation should include the current user.

Actual Result:

The copy at the beginning of the conversation is "This chat is with " which shows blank name.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6628148_1728379695818.20241008_172523.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843674144504172090
Upwork Job ID: 1843674144504172090
Last Price Increase: 2024-10-08

Issue Owner

Current Issue Owner: @parasharrajat

@madmax330

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Edited by proposal-police: This proposal was edited at 2024-10-08 10:29:59 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Blank name in "This chat is with " when creating group chat with yourself

What is the root cause of that problem?

From here we get the participant accountID and we pass true for shouldForceExcludeCurrentUser

App/src/libs/SidebarUtils.ts

Line 552 in 016822b

    
           const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined, true);

and in here we use shouldExcludeCurrentUser which will be true cause we are passing true for shouldForceExcludeCurrentUser

App/src/libs/ReportUtils.ts

Line 2129 in 016822b

    
           const shouldExcludeCurrentUser = isOneOnOneChat(report) || isSystemChat(report) || shouldForceExcludeCurrentUser;

What changes do you think we should make in order to solve the problem?

We can use isGroupchat check here

    const isGroupChat = ReportUtils.isGroupChat(report)

If isGroupChat is true we can pass false for shouldForceExcludeCurrentUser.

What alternative solutions did you explore? (Optional)

Alternative solution would be not to add any check

App/src/libs/SidebarUtils.ts

Line 552 in 016822b

    
           const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined, true);

    const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, undefined);

Alternative 2
Or we could simply add !isGroupChat here

      const shouldExcludeCurrentUser = isOneOnOneChat(report) || isSystemChat(report) || (shouldForceExcludeCurrentUser && !isGroupChat(report));

Job added to Upwork: https://www.upwork.com/jobs/~021843674144504172090

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@lschurr

Why would a user create a group chat with himself? Is this expected @lschurr @madmax330 ?

Shouldn't we prevent this from happening?

https://expensify.slack.com/archives/C01GTK53T8Q/p1728401433760799

OK so this is expected behaviour as per #39317 (comment).

@parasharrajat

@parasharrajat Are we considering this issue as a regression from #47427?

Doesn't look like it needs to be a blocker

@Nodebrute

@Nodebrute Yes. It is a regression from #47427

@nkdengineer

@nkdengineer is fixing this issue. we can remove help wanted label.

PR merged

Navigation Menu

Repository navigation

[$250] Group chat - Blank name in "This chat is with " when creating group chat with yourself #50390

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[$250] Group chat - Blank name in "This chat is with " when creating group chat with yourself #50390

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 8, 2024

melvin-bot commented on Oct 8, 2024

github-actions commented on Oct 8, 2024

Nodebrute commented on Oct 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Oct 8, 2024

melvin-bot commented on Oct 8, 2024

parasharrajat commented on Oct 8, 2024

parasharrajat commented on Oct 8, 2024

Nodebrute commented on Oct 8, 2024

thienlnam commented on Oct 8, 2024

parasharrajat commented on Oct 8, 2024

parasharrajat commented on Oct 9, 2024

parasharrajat commented on Oct 10, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions