[HOLD for payment 2024-11-14] Migrate MapView to useOnyx

@twisterdotcom

Problem

Coming from this PR ES Lint changed files check is failing because we need to migrate to useOnyx

#41242 (comment)

Solution

Do the migration

Issue Owner

Current Issue Owner: @twisterdotcom

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@janicduplessis

@janicduplessis is going to take this one since he touched the code that prompted the error.

I will take this!

Proposal

Please re-state the problem that we are trying to solve in this issue.

We are trying to migrate the MapView component from using the withOnyx HOC to the newer useOnyx hook.

What is the root cause of that problem?

The current implementation uses withOnyx, which is an older pattern for connecting components to Onyx data.

What changes do you think we should make in order to solve the problem?

In this file:

App/src/components/MapView/MapView.website.tsx

Line 35 in ba9af8f

const MapView = forwardRef<MapViewHandle, ComponentProps>(

Remove the withOnyx HOC from the MapView component.
Add the useOnyx hook inside the MapView component to fetch the userLocation data.

Add this code inside the component to get userLocation:

const [userLocation] = useOnyx({
    key: ONYXKEYS.USER_LOCATION,
});

Proposal

Please re-state the problem that we are trying to solve in this issue.

Migrate MapView to useOnyx

What is the root cause of that problem?

NA

What changes do you think we should make in order to solve the problem?

App/src/components/MapView/MapView.tsx

Lines 301 to 304 in d03066f

    
           export default withOnyx<ComponentProps, MapViewOnyxProps>({ 
        
               userLocation: { 
        
                   key: ONYXKEYS.USER_LOCATION, 
        
               },

We need to remove the withOnyx and use const [userLocation] = useOnyx(ONYXKEYS. USER_LOCATION);

What alternative solutions did you explore? (Optional)

@Shahidullah-Muffakir

@Shahidullah-Muffakir proposal looks good if you want to take this over.

@Shahidullah-Muffakir

@Shahidullah-Muffakir proposal looks good if you want to take this over.

@janicduplessis ,Sure, I can submit a PR. Thank you.

@Ollyws

Assigning @Ollyws as C+

Reviewing label has been removed, please complete the "BugZero Checklist".

@Ollyws

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

migrate from withOnyx HOC to the useOnyx hook #50443

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

@Ollyws requires payment through NewDot Manual Requests
@Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

@Ollyws

@Ollyws @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@Ollyws

Payment Summary

Upwork Job

Reviewer: @Ollyws owed $250 via NewDot
Contributor: @Shahidullah-Muffakir paid $250 via Upwork (https://www.upwork.com/nx/wm/offer/104898225)

BugZero Checklist (@twisterdotcom)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Requested in ND.

@Ollyws

$250 approved for @Ollyws

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-14] Migrate MapView to useOnyx #50343

Problem

Solution

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

5 remaining items

Payment Summary

BugZero Checklist (@twisterdotcom)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	export default withOnyx<ComponentProps, MapViewOnyxProps>({
	userLocation: {
	key: ONYXKEYS.USER_LOCATION,
	},

[HOLD for payment 2024-11-14] Migrate MapView to useOnyx #50343

Description

Problem

Solution

Activity

melvin-bot commented on Oct 7, 2024

neil-marcellini commented on Oct 7, 2024

janicduplessis commented on Oct 7, 2024

Shahidullah-Muffakir commented on Oct 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

cretadn22 commented on Oct 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

janicduplessis commented on Oct 8, 2024

Shahidullah-Muffakir commented on Oct 8, 2024

5 remaining items

neil-marcellini commented on Oct 30, 2024

melvin-bot commented on Nov 7, 2024

melvin-bot commented on Nov 7, 2024

melvin-bot commented on Nov 7, 2024

melvin-bot commented on Nov 14, 2024

Payment Summary

BugZero Checklist (@twisterdotcom)

Ollyws commented on Nov 14, 2024

garrettmknight commented on Nov 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions