Repository navigation
[Search v2.4] Search Router Polish Issues #50250
Description
- CMD + K should close the modal when it's already open
- Searching with filters that match a saved search should open the saved search in the LHN
- No need to show default searches in the recents.
- Clicking on a contextual filter in the search results takes you back to the default filters, rather than adding an extra search query to the existing search results. We need to preserve the current context and just add/update the type/status
- Using the router to
Search inand putting a link removes the link for the search results - If
Search insuggests a workspace chat, we should add thereportIDfilter instead ofin. Same goes for invoice and trip rooms - BUG: A parsing error occurs when special characters, such as ä, are used.
- Filter order changes when selected via UI vs typed in the input
- Typing amount>200 returns expenses with amounts below $200 (we are still processing the value as cents)
- Improve performance of filter validation
- Some hidden chats show up without a name
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
[-]Search Router Polish Issues[/-][+][Search v2.4] Search Router Polish Issues[/+]SzymczakJ commentedon Oct 7, 2024
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!
luacmartins commentedon Oct 7, 2024
@SzymczakJ just an FYI we're still adding more items to this issue as we test the feature
SzymczakJ commentedon Oct 8, 2024
Then I'll focus on other issues and come back to this PR later.
luacmartins commentedon Oct 10, 2024
Added a few more items to the list
289Adam289 commentedon Oct 11, 2024
I see the list is getting longer. I can also help with polish issues and follow ups from #49838
21 remaining items
melvin-bot commentedon Oct 22, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-29. 🎊
For reference, here are some details about the assignees on this issue:
[-][HOLD for payment 2024-10-29] [Search v2.4] Search Router Polish Issues[/-][+][Search v2.4] Search Router Polish Issues[/+]luacmartins commentedon Oct 29, 2024
PR addressing most of these issues was merged.
melvin-bot commentedon Nov 1, 2024
@luacmartins, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!
289Adam289 commentedon Nov 4, 2024
Hi! I've noticed two checkboxes that haven't been addressed yet. @luacmartins Could you describe those a bit more and maybe create separate issues with clear reproduction steps? Especially more information is needed for:
If we add the reportID instead of in user will not be able to quickly search for messages in the workspace chat. I am not entirely sure how to approach that.
luacmartins commentedon Nov 4, 2024
I'll create a separate issue for that and close this one.
luacmartins commentedon Nov 4, 2024
Created issue here - #51964