Repository navigation
[HOLD for payment 2024-11-01] [$250] Invoices - Amount shows 0.00 in invoice report and LHN after changing currency #50236
Description
Activity
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.We think that this bug might be related to #vip-bills
@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
- changed the title
[-]Invoices - Amount shows 0.00 in invoice report and LHN after changing currency[/-][+][$250] Invoices - Amount shows 0.00 in invoice report and LHN after changing currency[/+]on Oct 8, 2024 Job added to Upwork: https://www.upwork.com/jobs/~021843473405721154038
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)21 remaining items
Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-01. 🎊
For reference, here are some details about the assignees on this issue:
- @Ollyws requires payment through NewDot Manual Requests
- @nkdengineer requires payment automatic offer (Contributor)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
- [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@Ollyws] Determine if we should create a regression test for this bug.
- [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment Summary:
Contributor: @nkdengineer paid $250 via Upwork@Ollyws can you please complete the checklist and I'll organise your payment?
@VictoriaExpensify Will do, but I'm also due $250 for the review if you could add that to the summary, thanks.
BugZero Checklist:
- The PR that introduced the bug has been identified. Link to the PR:
This actually turned out to be partially a backend issue so we can't really pin it on any PR.
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
N/A
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
N/A
- Determine if we should create a regression test for this bug.
Yes.
- If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
1. Go to FAB > Send invoices. 2. Send an invoice in currency that matches the workspace default currency. 3. Go to invoice report. 4. Click Amount. 5. Change the currency to another currency and save it. 6. Verify that: Invoice report will display the correct amount in workspace default currency.Do we agree 👍 or 👎
@Ollyws the checklist gets completed before payment details get added to the summary :)
Updated payment summary:
Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @Ollyws owed $250 via NewDotRequested in ND.
$250 approved for @Ollyws
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5041108
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Invoice report will display the correct amount in workspace default currency.
Actual Result:
Invoice report shows 0.00 in report header, LHN and Total.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6624343_1728043017087.20241004_194816.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @VictoriaExpensify