[HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens

@jjcoffee

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.44-3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

Workspace has set up bank account.
Employee does not have personal bank account.

Go to staging.new.expensify.com
[Employee] Submit an expense in the workspace chat.
[Admin] Pay the expense via Expensify.
[Employee] Click on the expense preview.
[Employee] Click Add bank account button.

Expected Result:

The report view will persist when Add bank account RHP opens (production behavior).

Actual Result:

The report view changes to Wallet page when Add bank account RHP opens.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6623630_1727985420544.20241004_035429.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @jjcoffee

@bfitzexpensify

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@techievivek

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

We think that this bug might be related to #wave-collect - Release 1

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report view changes to Wallet page when Add bank account RHP opens.

What is the root cause of that problem?

The add personal bank account screen was mapped to settings profile screen:

App/src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts

Line 41 in d9882a3

SCREENS.SETTINGS.ADD_BANK_ACCOUNT,

What changes do you think we should make in order to solve the problem?

Add that screen to the RHP_SCREENS_OPENED_FROM_LHN:

App/src/libs/Navigation/linkingConfig/getAdaptedStateFromPath.ts

Line 24 in d8cda53

const RHP_SCREENS_OPENED_FROM_LHN = [

@mkzie2

@mkzie2 We require the original author to fix the regression issues and in this case it seems to be originating from this one https://github.com/Expensify/App/pull/49230/files

CC @daledah

There are already a few blocker linked to that PR so if the author is not online to fix it ASAP we might need to revert the original PR.

No payment due here as this was a regression fix.

@techievivek

@techievivek @bfitzexpensify Be sure to fill out the Contact List!

@jjcoffee

Reopening so @jjcoffee and @bfitzexpensify can fill out the regression checklist.

@jjcoffee

Payment Summary

Upwork Job

ROLE: @jjcoffee paid $(AMOUNT) via Upwork (LINK)
ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@bfitzexpensify)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

The PR that introduced the bug has been identified. Link to the PR: fix: requires validate when opening bank account #49230
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49230/files#r1816173504
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - missed testing buttons in other locations
Determine if we should create a regression test for this bug. Yes - if one doesn't exist
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Preconditions:

Workspace has set up bank account.
Employee does not have personal bank account.

[Employee] Submit an expense in the workspace chat.
[Admin] Pay the expense via Expensify.
[Employee] Click on the expense preview.
[Employee] Click Add bank account button.
[Employee] Verify that the report view will persist when Add bank account RHP opens

Do we agree 👍 or 👎

Looks good to me! Proposed in https://github.com/Expensify/Expensify/issues/438948

@techievivek

@techievivek @bfitzexpensify Be sure to fill out the Contact List!

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Navigation Menu

[HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens #50214

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

24 remaining items

Payment Summary

BugZero Checklist (@bfitzexpensify)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-24] Expense - Report view changes to Wallet page when Add bank account RHP opens #50214

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 4, 2024

melvin-bot commented on Oct 4, 2024

IuliiaHerets commented on Oct 4, 2024

github-actions commented on Oct 4, 2024

mkzie2 commented on Oct 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

techievivek commented on Oct 4, 2024

techievivek commented on Oct 4, 2024

24 remaining items

jjcoffee commented on Oct 17, 2024

melvin-bot commented on Oct 24, 2024

tgolen commented on Oct 24, 2024

melvin-bot commented on Oct 24, 2024

Payment Summary

BugZero Checklist (@bfitzexpensify)

jjcoffee commented on Oct 25, 2024

bfitzexpensify commented on Oct 25, 2024

melvin-bot commented on Oct 25, 2024

melvin-bot commented on Jan 2, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions