Skip to content

[HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted #50159

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.44-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh0110001@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Submit an expense with receipt to any user
  3. Go to transaction thread
  4. Click on the receipt
  5. Click 3-dot menu > Delete receipt
  6. Delete the receipt

Expected Result:

Add receipt modal will not disappear and reappear after the receipt is deleted

Actual Result:

Add receipt modal disappears and then reappears after the receipt is deleted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6623235_1727962475397.receipt.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841875580285563023
  • Upwork Job ID: 1841875580285563023
  • Last Price Increase: 2024-10-03
Issue OwnerCurrent Issue Owner: @kadiealexander

Activity

  1. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Oct 3, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. jasperhuangg commented on Oct 3, 2024

    @jasperhuangg
    Contributor

    This is a super minor display bug where some UI disappears for a split second when some state fields change on the page, definitely doesn't need to be a blocker.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 3, 2024
  5. changed the title [-]Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-] [+][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+] on Oct 3, 2024
  6. melvin-bot commented on Oct 3, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 3, 2024
  8. 12 remaining items

  9. nkdengineer commented on Oct 5, 2024

    @nkdengineer
    Contributor

    @dukenv0307 this PR is ready for review

  10. allgandalf commented on Oct 8, 2024

    @allgandalf
    Contributor

    I will unassign myself since this was a regression from previous PR

  11. removed their assignment
    on Oct 8, 2024
  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 9, 2024
  13. changed the title [-][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-] [+][HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+] on Oct 9, 2024
  14. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-16. 🎊

  16. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
    • [@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@thienlnam] Determine if we should create a regression test for this bug.
    • [@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. kadiealexander commented on Oct 15, 2024

    @kadiealexander
    Contributor

    Closing as no one is due payment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions