You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted #50159
Version Number: 9.0.44-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+kh0110001@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Submit an expense with receipt to any user
Go to transaction thread
Click on the receipt
Click 3-dot menu > Delete receipt
Delete the receipt
Expected Result:
Add receipt modal will not disappear and reappear after the receipt is deleted
Actual Result:
Add receipt modal disappears and then reappears after the receipt is deleted
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6623235_1727962475397.receipt.mp4
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This is a super minor display bug where some UI disappears for a split second when some state fields change on the page, definitely doesn't need to be a blocker.
changed the title [-]Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-][+][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+]on Oct 3, 2024
changed the title [-][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-][+][HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+]on Oct 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thienlnam] The PR that introduced the bug has been identified. Link to the PR:
[@thienlnam] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thienlnam] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thienlnam] Determine if we should create a regression test for this bug.
[@thienlnam] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 3, 2024
Triggered auto assignment to @thienlnam (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 3, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jasperhuangg commentedon Oct 3, 2024
This is a super minor display bug where some UI disappears for a split second when some state fields change on the page, definitely doesn't need to be a blocker.
[-]Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-][+][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+]melvin-bot commentedon Oct 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021841875580285563023
12 remaining items
nkdengineer commentedon Oct 5, 2024
@dukenv0307 this PR is ready for review
allgandalf commentedon Oct 8, 2024
I will unassign myself since this was a regression from previous PR
[-][$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/-][+][HOLD for payment 2024-10-16] [$250] Expense - Add receipt modal disappears and then reappears after the receipt is deleted[/+]melvin-bot commentedon Oct 9, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 9, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-16. 🎊
melvin-bot commentedon Oct 9, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kadiealexander commentedon Oct 15, 2024
Closing as no one is due payment here.