Skip to content

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Yellow color tones not applied for emoji #50087

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @techievivek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727840322244459

Action Performed:

  1. Set yellow color as a color tone for emojis
  2. Hover on a message and click on Add reaction > Select :thumpsup

Expected Result:

Emoji color tone shows in yellow

Actual Result:

But showing in different color

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Google Chrome 2024-10-02 at 10 19 58

Google Chrome 2024-10-02 at 10 19 50

Screenshot 2024-10-02 at 9 07 01 AM

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2024
  2. melvin-bot commented on Oct 2, 2024

    @melvin-bot

    Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Oct 2, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Oct 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. zfurtak commented on Oct 2, 2024

    @zfurtak
    Contributor

    Hello, this is cause by my recently merged PR and I would like to take of this issue (I work for swm agency)

  6. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    Contributor

    @zfurtak Please fix the regression, thanks!

  7. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    Contributor

    @zfurtak Are you actively looking into the fix for this issue?

  8. 12 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 3, 2024
  10. changed the title [-]Yellow color tones not applied for emoji[/-] [+][HOLD for payment 2024-10-10] Yellow color tones not applied for emoji[/+] on Oct 3, 2024
  11. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @zfurtak does not require payment (Contractor)
  13. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jasperhuangg / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
    • [@jasperhuangg / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jasperhuangg / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@zfurtak] Determine if we should create a regression test for this bug.
    • [@zfurtak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. changed the title [-][HOLD for payment 2024-10-10] Yellow color tones not applied for emoji[/-] [+][HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Yellow color tones not applied for emoji[/+] on Oct 4, 2024
  15. melvin-bot commented on Oct 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-11. 🎊

    For reference, here are some details about the assignees on this issue:

    • @zfurtak does not require payment (Contractor)
  16. melvin-bot commented on Oct 4, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@jasperhuangg / @roryabraham] The PR that introduced the bug has been identified. Link to the PR:
    • [@jasperhuangg / @roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@jasperhuangg / @roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@zfurtak] Determine if we should create a regression test for this bug.
    • [@zfurtak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions