Skip to content

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] mWeb - LHN - Emoji deleted in chat doesn´t disappear from preview in LHN #50069

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #49730

Action Performed:

  1. Open the staging.new.expensify.com website
  2. Open any chat
  3. Send any emoji
  4. Long tap over the emoji
  5. Tap on "Delete Message"
  6. Verify emoji disappears from chat
  7. Tap on the arrow on the top left corner
  8. Verify the emoji is no longer displayed on chat preview on LHN

Expected Result:

The deleted emoji should disappear from the chat and also from the chat preview in LHN

Actual Result:

When deleting an emoji, the emoji disappears from the chat, but is still displayed on the chat preview in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622060_1727870416191.Emoji_LHN.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployBlockerIndicates it should block deploying the API
    on Oct 2, 2024
  2. melvin-bot commented on Oct 2, 2024

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. github-actions commented on Oct 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    Contributor

    #50081 seems related to this, and @Beamanator is offline. @stitesExpensify can you see if a fix for this issue also solves that one?

  5. situchan commented on Oct 2, 2024

    @situchan
    Contributor

    This came from https://github.com/Expensify/App/pull/49534/files#diff-3258457b3b73b3f6fde322dfd4d925501f57daeee25e2ae30e671a53460aa06cR52-R56

    image

    Solution:

            if (!reportAction) {
    +           delete visibleReportActionItems[reportID];
                return;
            }
            visibleReportActionItems[reportID] = reportAction;

    I am available now to raise PR

  6. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    Contributor

    Asked QA for retest here

  7. jasperhuangg commented on Oct 2, 2024

    @jasperhuangg
    Contributor

    This was validated to be fixed via this

  8. 17 remaining items

  9. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  10. OfstadC commented on Oct 11, 2024

    @OfstadC
    Contributor

    @stitesExpensify Could you help me assess who needs payment here? 😅 I want to make sure i'm not missing anyone.

    Is it @situchan & @DylanDylann ? And is the price $250?

  11. DylanDylann commented on Oct 11, 2024

    @DylanDylann
    Contributor

    No need payment for me

  12. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  13. stitesExpensify commented on Oct 11, 2024

    @stitesExpensify
    Contributor
  14. OfstadC commented on Oct 11, 2024

    @OfstadC
    Contributor

    Thanks @stitesExpensify !

    Upwork Job

    @situchan Could you please accept this offer? Then I can issue payment. 😃 Thank you!

  15. OfstadC commented on Oct 14, 2024

    @OfstadC
    Contributor

    Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions