[HOLD for payment 2024-10-24] [$250] Error when copilot adds a new contact method

@anmurali

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.42-3
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49150
Issue reported by: Applause Internal Team

Action Performed:

Log in the App
Add a copilot to the user A
Login as copilot
Go to Account settings.
Click on the account switcher
Switch to user A account
Click Contact method.
Click New contact method.
Enter a new email address
Click Next

Expected Result:

The new email address is added as a new contact method.

Actual Result:

Copilot can not add new contact method. Error message "An unexpected error occurred when trying to add the new login.". RD in LHN-Profile, Profile window-Contact method, and LHP.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6622066_1727870652691.49150failst.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021842646552595795235
Upwork Job ID: 1842646552595795235
Last Price Increase: 2024-10-05
Automatic offers:

c3024 | Reviewer | 104335384

Issue Owner

Current Issue Owner: @anmurali

@anmurali

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@anmurali

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-08 14:47:15 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error when copilot adds a new contact method

What is the root cause of that problem?

Copilot does not have enough authorities to add new contact methods.

What changes do you think we should make in order to solve the problem?

Option 1.

Disable New Contact Method button if current user is a copilot.

    const [account] = useOnyx(ONYXKEYS.ACCOUNT);
    const isActingAsDelegate = !!account?.delegatedAccess?.delegate ?? false;
    .
    .
    .
    <Button
        isDisabled = {isActingAsDelegate}
        large
        success
        text={translate('contacts.newContactMethod')}
        onPress={onNewContactMethodButtonPress}
        pressOnEnter
    />

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Lines 125 to 131 in 3946b22

    
           <Button 
        
               large 
        
               success 
        
               text={translate('contacts.newContactMethod')} 
        
               onPress={onNewContactMethodButtonPress} 
        
               pressOnEnter 
        
           />

optionally we could add a short message above New Contact Method button to inform user that - copilot could not add new contact method.

Option 2.

Hide New Contact Method button if current user is copilot.

    const [account] = useOnyx(ONYXKEYS.ACCOUNT);
    const isActingAsDelegate = !!account?.delegatedAccess?.delegate ?? false;
    .
    .
    .
    { !isActingAsDelegate && <Button 
        large
        success
        text={translate('contacts.newContactMethod')}
        onPress={onNewContactMethodButtonPress}
        pressOnEnter
    />}

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Lines 125 to 131 in 3946b22

    
           <Button 
        
               large 
        
               success 
        
               text={translate('contacts.newContactMethod')} 
        
               onPress={onNewContactMethodButtonPress} 
        
               pressOnEnter 
        
           />

In addition to both of the above options - wrap NewContactMethodPage with AccessOrNotFoundWrapper to avoid copilot using deep link to access the page.

    <AccessOrNotFoundWrapper
        shouldBeBlocked = {isActingAsDelegate}
        .
        .
    >
        <ScreenWrapper
        .
        .
        </ScreenWrapper>
     </AccessOrNotFoundWrapper>

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Lines 103 to 152 in 3946b22

    
           <ScreenWrapper 
        
               onEntryTransitionEnd={() => loginInputRef.current?.focus()} 
        
               includeSafeAreaPaddingBottom={false} 
        
               shouldEnableMaxHeight 
        
               testID={NewContactMethodPage.displayName} 
        
           > 
        
               <HeaderWithBackButton 
        
                   title={translate('contacts.newContactMethod')} 
        
                   onBackButtonPress={onBackButtonPress} 
        
               /> 
        
               <FormProvider 
        
                   formID={ONYXKEYS.FORMS.NEW_CONTACT_METHOD_FORM} 
        
                   validate={validate} 
        
                   onSubmit={handleValidateMagicCode} 
        
                   submitButtonText={translate('common.add')} 
        
                   style={[styles.flexGrow1, styles.mh5]} 
        
               > 
        
                   <Text style={styles.mb5}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text> 
        
                   <View style={styles.mb6}> 
        
                       <InputWrapper 
        
                           InputComponent={TextInput} 
        
                           label={`${translate('common.email')}/${translate('common.phoneNumber')}`} 
        
                           aria-label={`${translate('common.email')}/${translate('common.phoneNumber')}`} 
        
                           role={CONST.ROLE.PRESENTATION} 
        
                           inputMode={CONST.INPUT_MODE.EMAIL} 
        
                           ref={loginInputRef} 
        
                           inputID={INPUT_IDS.PHONE_OR_EMAIL} 
        
                           autoCapitalize="none" 
        
                           enterKeyHint="done" 
        
                           maxLength={CONST.LOGIN_CHARACTER_LIMIT} 
        
                       /> 
        
                   </View> 
        
                   {hasFailedToSendVerificationCode && ( 
        
                       <DotIndicatorMessage 
        
                           messages={ErrorUtils.getLatestErrorField(pendingContactAction, 'actionVerified')} 
        
                           type="error" 
        
                       /> 
        
                   )} 
        
               </FormProvider> 
        
               <ValidateCodeActionModal 
        
                   validatePendingAction={pendingContactAction?.pendingFields?.actionVerified} 
        
                   validateError={validateLoginError} 
        
                   handleSubmitForm={addNewContactMethod} 
        
                   clearError={() => User.clearContactMethodErrors(contactMethod, 'validateLogin')} 
        
                   onClose={() => setIsValidateCodeActionModalVisible(false)} 
        
                   isVisible={isValidateCodeActionModalVisible} 
        
                   title={contactMethod} 
        
                   description={translate('contacts.enterMagicCode', {contactMethod})} 
        
               /> 
        
           </ScreenWrapper>

What alternative solutions did you explore? (Optional)

add DelegateNoAccessModal to NewContactMethodPage and when user is delegate and press New Contact Method button show DelegateNoAccessModal
we need to make few changes to DelegateNoAccessModal as well, since currently it has only prompt for limitedAccessDelegate but for this action here we also restrict fullAccessDelegate so we have too add prompt support for fullAccessDelegate

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Job added to Upwork: https://www.upwork.com/jobs/~021842646552595795235

@c3024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

@anmurali

@anmurali can you get it done today?
That would be helpful.

@Julesssss

@Julesssss, @anmurali, @ChavdaSachin, @c3024 Eep! 4 days overdue now. Issues have feelings too...

Offer is here

Accepted

@anmurali

friendly bump ^ @anmurali

@Julesssss

@Julesssss, @anmurali, @ChavdaSachin, @c3024 Eep! 4 days overdue now. Issues have feelings too...

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-24] [$250] Error when copilot adds a new contact method #50063

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

50 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Button
	large
	success
	text={translate('contacts.newContactMethod')}
	onPress={onNewContactMethodButtonPress}
	pressOnEnter
	/>

	<ScreenWrapper
	onEntryTransitionEnd={() => loginInputRef.current?.focus()}
	includeSafeAreaPaddingBottom={false}
	shouldEnableMaxHeight
	testID={NewContactMethodPage.displayName}
	>
	<HeaderWithBackButton
	title={translate('contacts.newContactMethod')}
	onBackButtonPress={onBackButtonPress}
	/>
	<FormProvider
	formID={ONYXKEYS.FORMS.NEW_CONTACT_METHOD_FORM}
	validate={validate}
	onSubmit={handleValidateMagicCode}
	submitButtonText={translate('common.add')}
	style={[styles.flexGrow1, styles.mh5]}
	>
	<Text style={styles.mb5}>{translate('common.pleaseEnterEmailOrPhoneNumber')}</Text>
	<View style={styles.mb6}>
	<InputWrapper
	InputComponent={TextInput}
	label={`${translate('common.email')}/${translate('common.phoneNumber')}`}
	aria-label={`${translate('common.email')}/${translate('common.phoneNumber')}`}
	role={CONST.ROLE.PRESENTATION}
	inputMode={CONST.INPUT_MODE.EMAIL}
	ref={loginInputRef}
	inputID={INPUT_IDS.PHONE_OR_EMAIL}
	autoCapitalize="none"
	enterKeyHint="done"
	maxLength={CONST.LOGIN_CHARACTER_LIMIT}
	/>
	</View>
	{hasFailedToSendVerificationCode && (
	<DotIndicatorMessage
	messages={ErrorUtils.getLatestErrorField(pendingContactAction, 'actionVerified')}
	type="error"
	/>
	)}
	</FormProvider>
	<ValidateCodeActionModal
	validatePendingAction={pendingContactAction?.pendingFields?.actionVerified}
	validateError={validateLoginError}
	handleSubmitForm={addNewContactMethod}
	clearError={() => User.clearContactMethodErrors(contactMethod, 'validateLogin')}
	onClose={() => setIsValidateCodeActionModalVisible(false)}
	isVisible={isValidateCodeActionModalVisible}
	title={contactMethod}
	description={translate('contacts.enterMagicCode', {contactMethod})}
	/>
	</ScreenWrapper>

[HOLD for payment 2024-10-24] [$250] Error when copilot adds a new contact method #50063

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 2, 2024

IuliiaHerets commented on Oct 2, 2024

IuliiaHerets commented on Oct 2, 2024

ChavdaSachin commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Oct 5, 2024

melvin-bot commented on Oct 5, 2024

50 remaining items

ChavdaSachin commented on Oct 30, 2024

melvin-bot commented on Nov 4, 2024

anmurali commented on Nov 6, 2024

ChavdaSachin commented on Nov 6, 2024

ChavdaSachin commented on Nov 7, 2024

melvin-bot commented on Nov 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions