Repository navigation
Close (X) button is not functioning for workspace card error messages. #50010
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.42-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727728301784899
Action Performed:
- [Admin] Create a new card.
- [Admin] Go to the card limit page and keep it open.
- [Owner] Deactivate the newly created card.
- [Admin] Change the card limit. At this point, the error message should appear.
- [Admin] Click X to dismiss or close the error message
Expected Result:
Error message dismissed
Actual Result:
Unable to dismiss the error message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
close-does-not-work.mov
Recording.614.mp4
Add any screenshot/video evidence
Activity
melvin-bot commentedon Oct 1, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Nodebrute commentedon Oct 1, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Close (X) button is not functioning for workspace card error messages.
What is the root cause of that problem?
We are not passing
onCloseprop hereAlso I think we don't have a function to clear errors
What changes do you think we should make in order to solve the problem?
We should pass a
onCloseprop hereAlso we need to create a new function to clear this error from onyx and then we can pass that function to
onCloseWhat alternative solutions did you explore? (Optional)
jayeshmangwani commentedon Oct 1, 2024
@bfitzexpensify Please close this issue, now we decided to fix this issue in this PR #49292 (comment)