Repository navigation
[HOLD for payment 2024-10-22] [$250] mWeb - Chat - The welcome group message doesn't update when a user is removed #49933
Description
Activity
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Proposal
Please re-state the problem that we are trying to solve in this issue.
The group welcome text doesn't immediately update its members/participant.
What is the root cause of that problem?
When we remove participant from the group, we don't immediately remove it from
participants, but rather put it inpendingChatMemberslist. After the request is success, the member will be removed.Currently, we show the list of the participants from the
participantswithout filtering the pending delete members.
App/src/components/ReportWelcomeText.tsx
Line 43 in e84dab7
Lines 2110 to 2112 in e84dab7
So, the text will still shows the pending delete member for a while.
What changes do you think we should make in order to solve the problem?
To not show the deleted member, we need to pass
shouldExcludeDeletedas true.const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report, undefined, true);I think we can make the default to true, but not sure why we made it false.- changed the title
[-]mWeb - Chat - The welcome group message doesn't update when a user is removed[/-][+][$250] mWeb - Chat - The welcome group message doesn't update when a user is removed[/+]on Oct 2, 2024 Job added to Upwork: https://www.upwork.com/jobs/~021841455012379899950
Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (
External)@bernhardoj Thank you for your proposal, your RCA is correct. Looks like fairly simple solution.
We can go with @bernhardoj 's proposal
C+ reviewed 🎀 👀 🎀
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
25 remaining items
Requested in ND.
$250 approved for @bernhardoj
Reacted by Sheena Trepanier- The PR that introduced the bug has been identified. Link to the PR: update beginningOfChatHistory translation #49919
- The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49919/files#r1812414693
- A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
- Determine if we should create a regression test for this bug. Straightforward fix, no need
Reacted by Sonia Liapounova@JmillsExpensify Checklist done
@alitoshmatov thanks! Payment completed ✔️
@sonialiap can you please copy the checklist answers from @alitoshmatov into the checklist comment above and then complete your checklist item?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR: update beginningOfChatHistory translation #49919
- [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49919/files#r1812414693
- [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
- [@alitoshmatov] Determine if we should create a regression test for this bug.: Straightforward fix, no need
- [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. : no need for regression test
- [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: no need for regression test
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR #49618
Action Performed:
Expected Result:
The removed user is not displayed in the welcome group message
Actual Result:
The removed user is still displayed in the welcome group message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6618968_1727571690696.49618-mWeb.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sonialiap