Copilot - No "on behalf of" header for expense preview

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N/A Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #48594

Action Performed:

Precondition:

Log in as a copilot

Go to staging.new.expensify.com
Go to Account settings
Click on the account switcher
Select the other account that user has full access to
Go to DM
Split an expense

Expected Result:

There will be "on behalf of" header for the split preview and expense preview

Actual Result:

"on behalf of" header is only present for the split preview but not expense preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617924_1727475165614.20240928_060800.mp4

View all open jobs on GitHub

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@francoisl

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

We think that this bug might be related to #wave-control

Proposal

Please re-state the problem that we are trying to solve in this issue.

No "on behalf of" header for expense preview

What is the root cause of that problem?

We are hiding this message if !isReportPreviewAction

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 379 to 381 in 461d574

    
           {action?.delegateAccountID && !isReportPreviewAction && ( 
        
               <Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text> 
        
           )}

What changes do you think we should make in order to solve the problem?

We can remove this check !isReportPreviewAction

App/src/pages/home/report/ReportActionItemSingle.tsx

Lines 379 to 381 in 461d574

    
           {action?.delegateAccountID && !isReportPreviewAction && ( 
        
               <Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text> 
        
           )}

What alternative solutions did you explore? (Optional)

@dangrous

I guess this issue should be closed, according to the design doc, we shouldn't have that header for expense preview

c.c. @dangrous @rushatgabhane @DylanDylann

Not a web-E blocker

@dylanexpensify

Yeah I think that's right, we can close this. cc @dylanexpensify

Navigation Menu

Repository navigation

Copilot - No "on behalf of" header for expense preview #49888

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	{action?.delegateAccountID && !isReportPreviewAction && (
	<Text style={[styles.chatDelegateMessage]}>{translate('delegate.onBehalfOfMessage', {delegator: accountOwnerDetails?.displayName ?? ''})}</Text>
	)}

Copilot - No "on behalf of" header for expense preview #49888

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Sep 28, 2024

melvin-bot commented on Sep 28, 2024

lanitochka17 commented on Sep 28, 2024

Nodebrute commented on Sep 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allgandalf commented on Sep 30, 2024

Gonals commented on Sep 30, 2024

dangrous commented on Sep 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions