[HOLD for payment 2024-10-10] [$250] [Search v2.1] Web - Search - App returns to Inbox after closing receipt view in Search

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat
Submit an expense with receipt
Go to Search
Click on the expense submitted in Step 3
Click on the receipt
Click X button

Expected Result:

App will return to search page with transaction thread RHP open

Actual Result:

App returns to transaction thread in Inbox

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6617905_1727473443637.20240928_054138.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021840734855215732913
Upwork Job ID: 1840734855215732913
Last Price Increase: 2024-09-30

Issue Owner

Current Issue Owner: @

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@luacmartins

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Production:

bandicam.2024-09-28.00-26-21-579.mp4

We think that this bug might be related to #wave-control

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

    
           onModalClose={() => { 
        
               Navigation.dismissModal(report?.reportID ?? '-1'); 
        
           }}

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

  Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(report?.reportID ?? '-1'));

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

    
           onModalClose={() => { 
        
               Navigation.dismissModal(report?.reportID ?? '-1'); 
        
           }}

What alternative solutions did you explore? (Optional)

Contributor details
Your Expensify account email: rijusougata13@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014959001a9ba2085d

@rijusougata13

📣 @rijusougata13! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Edited by proposal-police: This proposal was edited at 2024-09-28 23:05:57 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to Inbox after closing receipt view in Search

What is the root cause of that problem?

We are dismissing modal here whereas we just need to close the open reciept and use a general purpose function .

App/src/pages/TransactionReceiptPage.tsx

Lines 61 to 63 in 71db3f1

    
           onModalClose={() => { 
        
               Navigation.dismissModal(report?.reportID ?? '-1'); 
        
           }}

What changes do you think we should make in order to solve the problem?

We should use Navigation.goBack instead. We can do something like this

 onModalClose={() => { 
     Navigation.goBack(); 
 }}

Video

Screencast.from.2024-09-29.04-19-43.mp4

What alternative solutions did you explore? (Optional)

thouwhaleu Your proposal will be dismissed because you did not follow the proposal template.

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Kicu

Payment Summary

Upwork Job

Contributor: @Kicu is from an agency-contributor and not due payment
ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@zanyrenney)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1840734855215732913/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@rayane-djouah

bump @rayane-djouah can you apply to the job please? https://www.upwork.com/jobs/~021840734855215732913

@zanyrenney

@zanyrenney - Applied https://www.upwork.com/nx/proposals/1845826586166595585

@Kicu

Payment Summary

Upwork Job

Contributor: @Kicu is from an agency-contributor and not due payment - ✅
ROLE: @rayane-djouah paid $(AMOUNT) via Upwork (LINK) paid $250 via upwork ✅

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-10] [$250] [Search v2.1] Web - Search - App returns to Inbox after closing receipt view in Search #49887

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Video

What alternative solutions did you explore? (Optional)

31 remaining items

Payment Summary

BugZero Checklist (@zanyrenney)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	onModalClose={() => {
	Navigation.dismissModal(report?.reportID ?? '-1');
	}}

[HOLD for payment 2024-10-10] [$250] [Search v2.1] Web - Search - App returns to Inbox after closing receipt view in Search #49887

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Sep 28, 2024

melvin-bot commented on Sep 28, 2024

lanitochka17 commented on Sep 28, 2024

lanitochka17 commented on Sep 28, 2024

Nodebrute commented on Sep 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rijusougata13 commented on Sep 28, 2024

melvin-bot commented on Sep 28, 2024

sumairq commented on Sep 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Video

What alternative solutions did you explore? (Optional)

github-actions commented on Sep 28, 2024

31 remaining items

melvin-bot commented on Oct 9, 2024

melvin-bot commented on Oct 10, 2024

Payment Summary

BugZero Checklist (@zanyrenney)

zanyrenney commented on Oct 14, 2024

rayane-d commented on Oct 14, 2024

zanyrenney commented on Oct 14, 2024

Payment Summary

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions