Repository navigation
[$250] [Waiting for payment - 2024-10-06] iOS - Login - White screen persists for some time after login #49880
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Sep 28, 2024 github-actions commented
on Sep 28, 2024 on Sep 28, 2024 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Going to venture a guess that this is a front-end blocker, not a back-end blocker
- removedDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Sep 29, 2024 This doesn't occur every time on my account, but I can reproduce on
9.0.41.1and9.0.41.0.Not9.0.40.6. howeverThere are a lot of issues in the checklist. I'm working through them but in the meantime have asked for thoughts in Slack.
Edited by proposal-police: This proposal was edited at 2024-09-30 11:07:48 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
White screen persists for some time after login
What is the root cause of that problem?
- Come from PR.
- We return null when the data is loading:
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Lines 401 to 402 in 8636074
if (isLoadingOnyxValue(sessionStatus, lastOpenedPublicRoomIDStatus, initialLastUpdateIDAppliedToClientStatus)) { return; What changes do you think we should make in order to solve the problem?
- We should return
<FullScreenLoadingIndicator />instead. (Or another loading screen based on design)
What alternative solutions did you explore? (Optional)
@Julesssss Reverting #49185 also fixes this issue
Yeah, in this case a simple fix might be preferable.
36 remaining items
@Julesssss Sorry, do I and @allgandalf have payment based on comment?
Reacted by Jules- addedBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.
on Oct 8, 2024 Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.@allgandalf were you paid yet? I think probably not right?
@JmillsExpensify could you please pay out the following once this has been confirmed? Thanks
- @truph01 $125 for locating blocker (50%)
- @allgandalf $250 for review of revert PR
Looks like @allgandalf needs to be paid out via Upwork for the review. I'm taking care of that in this issue.
Yeah, that is why i asked to close this issue 😄
Oh right.
@johncschuster would you mind taking care of the other payment there too?
@truph01 $125 for locating blocker (50%)
Ugh, I missed ^that comment to issue payment for locating the blocker. I am so sorry, @truph01! Let me get an Upwork job going for that and I'll issue payment right away.
Reacted by Gandalf@truph01 can you accept this offer on Upwork when you get a moment?
@johncschuster Accepted, thank you 🙇
This has been paid! Thanks for flagging it, @truph01!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
There will be no white screen after login
Actual Result:
White screen persists for some time after login
On production, there is white screen but it appears very briefly
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6617803_1727467446758.ScreenRecording_09-28-2024_04-00-21_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @