Repository navigation
[HOLD for payment 2024-10-30] [$250] [Dupe detection] Report header has "Hold" action when the expense is already in Hold status #49872
Description
Activity
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
On prod, the other expense vanishes instantly
bandicam.2024-09-28.00-52-50-976.mp4
We think that this bug might be related to #wave-collect - Release 1
Dupe detection is behind a beta w/ only internal users and developers, this is NAB
46 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
For reference, here are some details about the assignees on this issue:
- @eVoloshchak requires payment through NewDot Manual Requests
- @daledah requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
- [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@eVoloshchak] Determine if we should create a regression test for this bug.
- [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Payment Summary
- Reviewer: @eVoloshchak owed $250 via NewDot
- ROLE: @daledah paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@stephanieelliott)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1840780088904015602/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Summarizing payment on this issue:
- Contributor: @eVoloshchak $250 via NewDot - Please request
- Contributor+: @daledah $250 via Upwork - PAID
Upwork job is here: https://www.upwork.com/jobs/~021851909474139768777
@stephanieelliott accepted thx
All paid!
@stephanieelliott @jasperhuangg Be sure to fill out the Contact List!
$250 approved for @eVoloshchak
Metadata
Metadata
Labels
Type
Projects
- Status
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.41-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48522
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Since the other expense has "Hold" action, the report header should have the "Unhold" action.
Actual Result:
The report header has "Hold" action when the expense is already in Hold status.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6617758_1727464896179.20240928_031804.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliott