Skip to content

createPrerelease is run and fails when a deploy is canceled due to cancel-in-progress #49851

Closed

Description

@AndrewGable

Problem

We had a deploy error on https://github.com/Expensify/App/actions/runs/11074305525/job/30773368164 because the build was canceled due to cancel-in-progress flag.

Solution

@roryabraham says:

I'd say this is expected - the deploy completed on at least one platform (web), so it creates the prerelease.
I think we should just continue-on-error with these non-critical artifact upload steps

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Sep 27, 2024
  2. roryabraham commented on Sep 27, 2024

    @roryabraham
    Contributor

    Going to just create a quick PR

  3. roryabraham commented on Sep 28, 2024

    @roryabraham
    Contributor

    Should be fixed by #49852. We don't have a great way to test this per-se so I'm going to optimistically close it and we can monitor/reopen if we see it happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions