[HOLD for payment 2024-10-16] [$250] Expensify card - Expensify card link navigates to wallet instead of virtual card details

@slafortune

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.40-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5012494
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://staging.new.expensify.com/
and log in
Create a workspace
Navigate to the workspace settings > More Features
Enable Expensify card option
Navigate to the Expensify card and click on Issue card
Select Connect online with plaid and add the VBA
Issue the virtual Expensify card to the current user
Navigate to the workspace chat
Click on the Expensify card link

Expected Result:

User is navigated to the virtual Expensify card details

Actual Result:

User is navigated to the wallet

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6616228_1727362608047.Recording__816.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021839673843128973218
Upwork Job ID: 1839673843128973218
Last Price Increase: 2024-09-27
Automatic offers:

jjcoffee | Reviewer | 104214637
truph01 | Contributor | 104214639

Issue Owner

Current Issue Owner: @slafortune

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

I will check the redirection logic written there and modify it as per requirements to redirect it to wallets.

@jais-nikhil

📣 @jais-nikhil! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Edited by proposal-police: This proposal was edited at 2024-10-01 10:50:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

User is navigated to the wallet

What is the root cause of that problem?

We always navigate the user to wallet page via:

App/src/libs/ReportActionsUtils.ts

Lines 1750 to 1751 in 70a8a16

    
           const link = shouldRenderHTML 
        
               ? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${Localize.translateLocal('cardPage.expensifyCard')}</a>`

What changes do you think we should make in order to solve the problem?

We should add additional params policyID, cardID to:

App/src/libs/ReportActionsUtils.ts

Line 1745 in 70a8a16

    
           function getCardIssuedMessage(reportAction: OnyxEntry<ReportAction>, shouldRenderHTML = false) {

and instead of ROUTES.SETTINGS_WALLET in:

App/src/libs/ReportActionsUtils.ts

Line 1751 in 70a8a16

    
           ? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${Localize.translateLocal('cardPage.expensifyCard')}</a>`

use:

ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS.getRoute(policyID, cardID)

policyID and cardID are passed down in where getCardIssuedMessage is called:

App/src/components/ReportActionItem/IssueCardMessage.tsx

Line 45 in 70a8a16

<RenderHTML html={`<muted-text>${ReportActionsUtils.getCardIssuedMessage(action, true)}</muted-text>`} />

Additionally:

Logic displays the report's name:

App/src/libs/ReportUtils.ts

Lines 3838 to 3840 in c7ee85b

    
           if (ReportActionsUtils.isCardIssuedAction(parentReportAction)) { 
        
               return ReportActionsUtils.getCardIssuedMessage(parentReportAction); 
        
           }

Logic displays the last message text in LHN:

App/src/libs/SidebarUtils.ts

Lines 435 to 436 in c7ee85b

    
           } else if (ReportActionsUtils.isCardIssuedAction(lastAction)) { 
        
               result.alternateText = ReportActionsUtils.getCardIssuedMessage(lastAction);

Logic displays copy message:

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Lines 482 to 483 in c7ee85b

    
           } else if (ReportActionsUtils.isCardIssuedAction(reportAction)) { 
        
               setClipboardMessage(ReportActionsUtils.getCardIssuedMessage(reportAction, true));

The getCardIssuedMessage are used in the above places. If we update getCardIssuedMessage function, these places will auto work properly.

What alternative solutions did you explore? (Optional)

We can navigate to another page instead of ROUTES.WORKSPACE_EXPENSIFY_CARD_DETAILS.getRoute(policyID, cardID) based on future discussion.

Job added to Upwork: https://www.upwork.com/jobs/~021839673843128973218

@jjcoffee

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

@jjcoffee

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.46-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: Expensify card link navigates to wallet #50039

If no regressions arise, payment will be issued on 2024-10-16. 🎊

For reference, here are some details about the assignees on this issue:

@jjcoffee requires payment automatic offer (Reviewer)
@truph01 requires payment automatic offer (Contributor)

@jjcoffee

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
[@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jjcoffee] Determine if we should create a regression test for this bug.
[@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jjcoffee

@jjcoffee can you please complete the checklist?

The PR that introduced the bug has been identified. Link to the PR: N/A - this was a missing feature in [NoQA] Feat/44307 card system messages #46281
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

[Admin] On a workspace with Expensify cards enabled, navigate to Workspace Settings > Expensify card
[Admin] Click on Issue card and issue a virtual Expensify card to any non-admin workspace member
[Admin] Navigate to the workspace chat
[Admin] Verify that tapping the Expensify card link in the card issued message opens the virtual Expensify card details.
[Non-admin] Log in as the user to whom the card was assigned.
[Non-admin] Open the same workspace chat.
[Non-admin] Verify that tapping the Expensify card link in the card issued message opens the virtual Expensify card details.

Do we agree 👍 or 👎

@slafortune

@slafortune All done!

@jjcoffee

@jjcoffee Role - C+ - Paid $250 via Upwork
@truph01 Role - Contributor - Paid $250 via Upwork

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-16] [$250] Expensify card - Expensify card link navigates to wallet instead of virtual card details #49804

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Additionally:

What alternative solutions did you explore? (Optional)

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const link = shouldRenderHTML
	? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${Localize.translateLocal('cardPage.expensifyCard')}</a>`

	if (ReportActionsUtils.isCardIssuedAction(parentReportAction)) {
	return ReportActionsUtils.getCardIssuedMessage(parentReportAction);
	}

	} else if (ReportActionsUtils.isCardIssuedAction(lastAction)) {
	result.alternateText = ReportActionsUtils.getCardIssuedMessage(lastAction);

	} else if (ReportActionsUtils.isCardIssuedAction(reportAction)) {
	setClipboardMessage(ReportActionsUtils.getCardIssuedMessage(reportAction, true));

[HOLD for payment 2024-10-16] [$250] Expensify card - Expensify card link navigates to wallet instead of virtual card details #49804

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 26, 2024

jais-nikhil commented on Sep 26, 2024

melvin-bot commented on Sep 26, 2024

truph01 commented on Sep 26, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Additionally:

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 27, 2024

melvin-bot commented on Sep 27, 2024

16 remaining items

melvin-bot commented on Oct 9, 2024

melvin-bot commented on Oct 9, 2024

melvin-bot commented on Oct 9, 2024

slafortune commented on Oct 17, 2024

jjcoffee commented on Oct 18, 2024

jjcoffee commented on Oct 18, 2024

slafortune commented on Oct 18, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions