[$250] [HOLD for payment 2024-10-17] [Wave Control] [QBD] Handle the initial connection for QBD #49697

Activity

1. lakchote

   added

   Engineering

   WeeklyKSv2KSv2

   on Sep 25, 2024
2. lakchote

   self-assigned this

   on Sep 25, 2024
3. lakchote

   added this to #expensify-bugson Sep 25, 2024
4. lakchote

   moved this to Release 3: Fall 2024 (Nov) in #expensify-bugson Sep 25, 2024
5. lakchote

   changed the title [-][HOLD E#430951] Handle the initial connection for QBD[/-] [+][HOLD E#430951] [Wave Control] [QBD] Handle the initial connection for QBD[/+] on Sep 25, 2024
6. lakchote

   changed the title [-][HOLD E#430951] [Wave Control] [QBD] Handle the initial connection for QBD[/-] [+][Wave Control] [QBD] Handle the initial connection for QBD[/+] on Oct 2, 2024
7. lakchote

   assigned

   hoangzinh

   on Oct 3, 2024
8. melvin-bot

   added

   ReviewingHas a PR in reviewHas a PR in review

   WeeklyKSv2KSv2

   Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

   and removed

   WeeklyKSv2KSv2

   on Oct 7, 2024
9. melvin-bot

   changed the title [-][Wave Control] [QBD] Handle the initial connection for QBD[/-] [+][HOLD for payment 2024-10-17] [Wave Control] [QBD] Handle the initial connection for QBD[/+] on Oct 10, 2024
10. 13 remaining items

    Load more

11. melvin-bot commented on Oct 18, 2024

    

    melvin-botBot

    on Oct 18, 2024 – with Melvin Bot

    More actions

    Job added to Upwork: https://www.upwork.com/jobs/~021847419775270058956
12. melvin-bot

    added

    Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

    on Oct 18, 2024
13. melvin-bot commented on Oct 18, 2024

    

    melvin-botBot

    on Oct 18, 2024 – with Melvin Bot

    More actions

    Current assignee @hoangzinh is eligible for the External assigner, not assigning anyone new.
14. mallenexpensify commented on Oct 18, 2024

    

    mallenexpensify

    on Oct 18, 2024

    Contributor

    More actions

    @hoangzinh can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021847419775270058956

    You were assigned on the date of your eligibility, since you're not setup on NewDot payments yet and I want to err on the safe side, I want to pay this via Upwork.
15. mallenexpensify

    removed

    Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

    on Oct 18, 2024
16. hoangzinh commented on Oct 21, 2024

    

    hoangzinh

    on Oct 21, 2024

    Contributor

    More actions

    Accepted the offer. Btw @mallenexpensify, @ZhenjaHorbach should be assigned to this issue as a C+ too.
17. mallenexpensify

    assigned

    ZhenjaHorbach

    on Oct 22, 2024
18. melvin-bot commented on Oct 22, 2024

    

    melvin-botBot

    on Oct 22, 2024 – with Melvin Bot

    More actions

    📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
19. melvin-bot commented on Oct 22, 2024

    

    melvin-botBot

    on Oct 22, 2024 – with Melvin Bot

    More actions

    📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖
20. mallenexpensify commented on Oct 22, 2024

    

    mallenexpensify

    on Oct 22, 2024

    Last edited by mallenexpensify

    Contributor

    More actions

    Contributor: @hoangzinh paid $250 via Upwork
    Contributor+: @ZhenjaHorbach paid $250 via Upwork

    @ZhenjaHorbach can you please accept the job and reply here once you have?
    https://www.upwork.com/jobs/~021847419775270058956

    Also, plz complete the BZ checklist.

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@] The PR that introduced the bug has been identified. Link to the PR:
    • [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@] Determine if we should create a regression test for this bug.
    • [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
21. ZhenjaHorbach commented on Oct 22, 2024

    

    ZhenjaHorbach

    on Oct 22, 2024

    Last edited by ZhenjaHorbach

    Contributor

    More actions

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@] The PR that introduced the bug has been identified. Link to the PR:

    New feature

    • [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    New feature

    • [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    NA

    • [@] Determine if we should create a regression test for this bug.
    • [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    • Sign in on an account that enabled beta quickbooksDesktopOnNewDot
    • Go to any Workspace
    • Enable Accounting if it hasn't enabled
    • Go to Workspace's Accounting
    • Verify that the QuickBooks Desktop connection is available
    • Click on "Connect" button
    • Verify that it shows "QuickBooks Desktop setup" page with the setup link for Web/Desktop
    • Verify that it shows "Can't connect from this device" page for mWeb/Native apps
22. ZhenjaHorbach commented on Oct 22, 2024

    

    ZhenjaHorbach

    on Oct 22, 2024

    Contributor

    More actions

    @mallenexpensify
    I accepted the offer and added BugZero Checklist
    Thanks !
23. mallenexpensify commented on Oct 22, 2024

    

    mallenexpensify

    on Oct 22, 2024

    Contributor

    More actions

    Thanks @ZhenjaHorbach , you've ben paid, payment confirmation updated above

    test case created

    • https://github.com/Expensify/Expensify/issues/438053

    ❤️React with ❤️1Reacted by Yauheni Horbach
24. mallenexpensify

    closed this as completedon Oct 22, 2024
25. github-project-automation

    moved this from Hold for Payment to Done in #expensify-bugson Oct 22, 2024