Repository navigation
[HOLD for payment 2024-10-30] [Debug Mode] Show reason for RBR/GBR on LHN tabs #49600
Description
Activity
Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time⚠️ Triggered auto assignment to Design team member for new feature review - @dannymcclain (
NewFeature)@dannymcclain un-assigning you since this is for debug mode, so I don't think there will be any UI considerations. But if there do end up being, I'll assign you back!
Reacted by Danny McClainHi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!
@puneetlath I'll open a PR soon for this! 😄
I'm currently working on getting the settings GBR/RBR causes and setting the logic to redirect users to what is triggering those GBR/RBR.
Reacted by Fábio Henriques, Matt Moore and Puneet Lath19 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
For reference, here are some details about the assignees on this issue:
- @pac-guerreiro does not require payment (Contractor)
- @DylanDylann requires payment (Needs manual offer from BZ)
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
- [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Payment Summary
- Contributor: @pac-guerreiro is from an agency-contributor and not due payment
- ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)
BugZero Checklist (@puneetlath)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
@DylanDylann shall we add a regression test here?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.Regression Test Proposal
- Go to App
- Open debug mode
- Verify that LHN shows a green indicator and a message to explain on the bottom if there is any GBR on LHN items or LHN shows a red indicator and a message to explain on the bottom if there is any RBR on LHN.
- Click on View button on the indicator
- Navigate to the place that caused RBR/GBR
Do we agree 👍 or 👎
@puneetlath, @pac-guerreiro, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?
I'll add this as a milestone to this offer once it has been accepted. @DylanDylann please ping me here when you've accepted it.
@puneetlath Accepted 🙏
Paid the milestone.
Regression test here: https://github.com/Expensify/Expensify/issues/442242
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
I would like to add a feature to the Debug Mode functionality, where if a user has an RBR or GBR on any of the three LHN tabs -- Inbox, Search, Account Settings -- we tell you what the reason is for that RBR/GBR being there.
For example, in this image, I have an RBR on the Inbox tab. I would like to be able to see what is causing that RBR.
Issue Owner
Current Issue Owner: @puneetlath