Skip to content

[HOLD for payment 2024-10-11] [$250] mWeb - Search - Holding on a pinned message scrolls the page #49537

Closed
Closed
[HOLD for payment 2024-10-11] [$250] mWeb - Search - Holding on a pinned message scrolls the page#49537
Assignees
BeamanatorbernhardojVictoriaExpensifyc3024
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Sep 20, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.39-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #49186
Email or phone of affected tester (no customers): nathanmulugetatesting+1580@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Start a chat with multiple accounts
  3. Pin every chat
  4. Go to search > Chat > Pinned tab
  5. Scroll down a bit and hold down on a message

Expected Result:

Nothing happens

Actual Result:

The page scrolls a bit

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6609929_1726837109164.Screen_Recording_20240920_155420_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021837159344756059487
  • Upwork Job ID: 1837159344756059487
  • Last Price Increase: 2024-09-20
  • Automatic offers:
    • c3024 | Reviewer | 104202793
Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 20, 2024
  2. melvin-bot
    assigned
    VictoriaExpensify
    on Sep 20, 2024

  3. melvin-bot commented on Sep 20, 2024

    @melvin-bot
    melvin-botbot
    on Sep 20, 2024 – with Melvin Bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    added
    DailyKSv2
    on Sep 20, 2024
  5. melvin-bot
    assigned
    Beamanator
    on Sep 20, 2024

  6. melvin-bot commented on Sep 20, 2024

    @melvin-bot
    melvin-botbot
    on Sep 20, 2024 – with Melvin Bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Sep 20, 2024

  8. github-actions commented on Sep 20, 2024

    @github-actions
    github-actionsbot
    on Sep 20, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. luacmartins commented on Sep 20, 2024

    @luacmartins
    luacmartins
    on Sep 20, 2024
    Contributor

    This is a pretty edge case scenario. I think we can demote it to NAB

  10. Beamanator
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Sep 20, 2024

  11. 34 remaining items

  12. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botbot
    on Oct 4, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-11. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botbot
    on Oct 4, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 11, 2024

  15. VictoriaExpensify commented on Oct 14, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Oct 14, 2024
    Contributor

    Payment Summary:
    Contributor: @bernhardoj owed $250 via NewDot
    Contributor+: @c3024 - please complete the checklist so I can organise payment - thanks!

  16. bernhardoj commented on Oct 14, 2024

    @bernhardoj
    bernhardoj
    on Oct 14, 2024
    Contributor

    Requested in ND.

  17. c3024 commented on Oct 15, 2024

    @c3024
    c3024
    on Oct 15, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: This is a bug peculiar to Android Chrome. No PR can be held responsible.
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this could not have been identified earlier.
    • [@c3024] Determine if we should create a regression test for this bug. Yes
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    Applicable only for Android Chrome

    1. Logon to ND
    2. Click on 'Search' in bottom tab bar.
    3. Click on 'Chats' on left pane.
    4. Long press on a message on the center pane.
    5. Verify that the message list doesn't scroll.

  18. c3024 commented on Oct 15, 2024

    @c3024
    c3024
    on Oct 15, 2024
    Contributor

    @VictoriaExpensify, checklist completed. Thanks!

  19. JmillsExpensify commented on Oct 15, 2024

    @JmillsExpensify
    JmillsExpensify
    on Oct 15, 2024
    Contributor

    $250 approved for @bernhardoj

  20. melvin-bot
    added
    Overdue
    on Oct 16, 2024

  21. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botbot
    on Oct 17, 2024 – with Melvin Bot

    @Beamanator, @bernhardoj, @VictoriaExpensify, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  22. VictoriaExpensify commented on Oct 18, 2024

    @VictoriaExpensify
    VictoriaExpensify
    on Oct 18, 2024
    Contributor

    Payment summary:
    Contributor+: @c3024 paid $250 via Upwork

  23. VictoriaExpensify
    closed this as completedon Oct 18, 2024
  24. melvin-bot
    removed
    Overdue
    on Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions