Repository navigation
[HOLD for payment 2024-10-04] [$250] Chat - New message line marker shown in the wrong position #49525
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Action Performed:
- Navigate to staging.new.expensify.com
- Receive multiple messages from another account
- Open another report and open the chat again to remove the unread marker
- Reply in thread on one of the sent messages
- Send a reply and go back by using the from link
Expected Result:
No new line marker gets shown
Actual Result:
New line marker shown under the message which has a reply
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6608923_1726754307057.video_2024-09-19_16-54-39.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021838488357896477944
- Upwork Job ID: 1838488357896477944
- Last Price Increase: 2024-09-24
Activity
melvin-bot commentedon Sep 20, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Sep 20, 2024
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Sep 23, 2024
@kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Chat - New message line marker shown in the wrong position[/-][+][$250] Chat - New message line marker shown in the wrong position[/+]melvin-bot commentedon Sep 24, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021838488357896477944
melvin-bot commentedon Sep 24, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)klajdipaja commentedon Sep 24, 2024
We have a PR that addresses a different bug in the mark as unread functionality from issue#47817 that I worked on. The result of that PR is that the marker line does not show on the main chat when a message in a thread is marked unread.
If it is expected that the thread itself also shows as unread than I can work on this issue after the initial one is merged. IMO the New Message marker here would be confusing as it creates the idea that all messages in the main chat are unread were in fact only in the thread there are unread messages. We should add an indicator in the thread itself, for example if the user has 4 replies and 1 is new based the mark unread functionality, we can show: "1 New reply" instead of "4 Replies".
FYI @mollfpr
9 remaining items
s77rt commentedon Sep 26, 2024
🎀 👀 🎀 For engineer PR revert review
melvin-bot commentedon Sep 26, 2024
Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
dangrous commentedon Sep 26, 2024
Left one comment on the linked PR.
Do I need to assign anyone here or are we all set?
s77rt commentedon Sep 26, 2024
All set
[-][$250] Chat - New message line marker shown in the wrong position[/-][+][HOLD for payment 2024-10-04] [$250] Chat - New message line marker shown in the wrong position[/+]melvin-bot commentedon Sep 27, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Sep 27, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.40-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Sep 27, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon Sep 28, 2024
No checklist needed. We just reverted the offending PR.