Skip to content

[PAID] [$250] [Workspace Feeds] App crashes after creating new WS and selecting start over #49447

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Unable to validate in Prod because of Bank Setup
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Create a workspace
  3. Navigate to More features and enable Expensify card
  4. Tap Issue new card > select Connect online with Plaid and add VBA
  5. Create a new workspace and enable Expensify card in More features
  6. Tap Issue new card > + Add a new bank account and select Start over

Expected Result:

The options to add a bank account using Plaid or entering manually are displayed

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1909_1.txt

2634362407034603675.MP4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021836823617385889668
  • Upwork Job ID: 1836823617385889668
  • Last Price Increase: 2024-10-24
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 19, 2024
  2. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Sep 19, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Sep 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. IuliiaHerets commented on Sep 19, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 2

  6. koko57 commented on Sep 19, 2024

    @koko57
    Contributor

    @trjExpensify @mountiny should it be a deploy blocker?

    I can investigate this issue

  7. Julesssss commented on Sep 19, 2024

    @Julesssss
    Contributor

    I'm just trying to figure out why this isn't testable in prod.

    Unable to validate in Prod because of Bank Setup

    @IuliiaHerets is it possible to test in prod with a different account? Or is this due to product functionality not being available?

  8. 97 remaining items

  9. changed the title [-][HOLD for payment 2024-10-16] [$250] [Workspace Feeds] App crashes after creating new WS and selecting start over[/-] [+][PAID] [$250] [Workspace Feeds] App crashes after creating new WS and selecting start over[/+] on Oct 23, 2024
  10. tgolen commented on Oct 23, 2024

    @tgolen
    Contributor

    Reopening for @DylanDylann and @CortneyOfstad to complete the regression checklist.

  11. reopened this on Oct 23, 2024
  12. DylanDylann commented on Oct 24, 2024

    @DylanDylann
    Contributor

    @mountiny Do we include this regression test overall on the project?

  13. mountiny commented on Oct 24, 2024

    @mountiny
    Contributor

    I think this is a niche flow that would not make sense to create a regression test for Applause to run through with every test. Can you complete the rest of the checklist please?

  14. CortneyOfstad commented on Oct 24, 2024

    @CortneyOfstad
    Contributor

    I'm back from OoO (thanks @strepanier03 for holding down the fort!)

  15. melvin-bot commented on Oct 24, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  16. DylanDylann commented on Oct 25, 2024

    @DylanDylann
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: It more like a new improvement
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. No
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Do we agree 👍 or 👎

  17. CortneyOfstad commented on Oct 28, 2024

    @CortneyOfstad
    Contributor

    Looks good @DylanDylann! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions