[HOLD for production 2024-10-07][$250] [Search v2.3] Add the bookmark icon for Saved searches on mobile #49442

Activity

1. lakchote

   added

   Engineering

   DailyKSv2KSv2

   on Sep 19, 2024
2. lakchote

   self-assigned this

   on Sep 19, 2024
3. lakchote

   added this to #expensify-bugson Sep 19, 2024
4. lakchote

   moved this to Polish in #expensify-bugson Sep 19, 2024
5. lakchote

   added

   ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributor

   Help WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors

   on Sep 19, 2024
6. melvin-bot commented on Sep 19, 2024

   

   melvin-botbot

   on Sep 19, 2024 – with Melvin Bot

   More actions

   Job added to Upwork: https://www.upwork.com/jobs/~021836682788967357264
7. melvin-bot

   changed the title [-][Search v2.3] Add the bookmark icon for Saved searches on mobile[/-] [+][$250] [Search v2.3] Add the bookmark icon for Saved searches on mobile[/+] on Sep 19, 2024
8. melvin-bot

   assigned

   thesahindia

   on Sep 19, 2024
9. melvin-bot commented on Sep 19, 2024

   

   melvin-botbot

   on Sep 19, 2024 – with Melvin Bot

   More actions

   Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)
10. mkzie2 commented on Sep 19, 2024

    

    mkzie2

    on Sep 19, 2024

    Contributor

    More actions

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add the bookmark icon for Saved searches on mobile

    What is the root cause of that problem?

    On mobile, we display the saved search query that we're viewing here

    App/src/pages/Search/SearchTypeMenuNarrow.tsx

    Line 87 in 37bf6b2

    if (title) {

    And we don't add icon field for the saved searches item
    

    App/src/pages/Search/SearchTypeMenuNarrow.tsx

    Line 108 in 37bf6b2

    const savedSearchItems = savedSearchesMenuItems.map((item) => ({

    What changes do you think we should make in order to solve the problem?

    We should remove this item here because it will be included in the savedSearchItems below or we can exclude the viewing saved search in savedSearchItems

    App/src/pages/Search/SearchTypeMenuNarrow.tsx

    Line 87 in 37bf6b2

    if (title) {

    Add icon field as Expensicons.BookMark here, we can also add other icon config field if it needs

    icon: Expensicons.Bookmark,
    

    App/src/pages/Search/SearchTypeMenuNarrow.tsx

    Line 108 in 37bf6b2

    const savedSearchItems = savedSearchesMenuItems.map((item) => ({

    What alternative solutions did you explore? (Optional)
11. thesahindia commented on Sep 19, 2024

    

    thesahindia

    on Sep 19, 2024

    Last edited by thesahindia

    Member

    More actions

    We should remove this item here because it will be included in the savedSearchItems below or we can exclude the viewing saved search in savedSearchItems

    The solution for adding icon is fine but I am not sure I understand what you said above. Could you explain it?
12. mkzie2 commented on Sep 19, 2024

    

    mkzie2

    on Sep 19, 2024

    Contributor

    More actions

    If we're viewing a saved search, we shouldn't add the custom query option to the bottom modal. Example: In the imagine below, the type:expense status:all currency:ALL AMD shouldn't be shown

    As the ref comment here mentioned, we shouldn't display the viewing saved search query in popoverMenuItems or savedSearchItems
13. thesahindia commented on Sep 19, 2024

    

    thesahindia

    on Sep 19, 2024

    Member

    More actions

    Got it!
14. 22 remaining items

    Load more

15. lakchote commented on Oct 18, 2024

    

    lakchote

    on Oct 18, 2024

    ContributorAuthor

    More actions

    @VictoriaExpensify please process payment for @mkzie2, thanks!
16. luacmartins

    changed the title [-][$250] [Search v2.3] Add the bookmark icon for Saved searches on mobile[/-] [+][HOLD for production 2024-10-07][$250] [Search v2.3] Add the bookmark icon for Saved searches on mobile[/+] on Oct 21, 2024
17. luacmartins

    added

    Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to production

    and removed

    ReviewingHas a PR in reviewHas a PR in review

    on Oct 21, 2024
18. melvin-bot

    added

    Overdue

    on Oct 21, 2024
19. melvin-bot commented on Oct 21, 2024

    

    melvin-botbot

    on Oct 21, 2024 – with Melvin Bot

    More actions

    @lakchote, @luacmartins, @VictoriaExpensify, @thesahindia, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!
20. luacmartins commented on Oct 21, 2024

    

    luacmartins

    on Oct 21, 2024

    Contributor

    More actions

    Waiting on payment
21. VictoriaExpensify commented on Oct 22, 2024

    

    VictoriaExpensify

    on Oct 22, 2024

    Contributor

    More actions

    Hey @mkzie2 - can you please accept the job offer and I'll organise payment
    https://www.upwork.com/nx/wm/offer/104530588
22. melvin-bot

    removed

    Overdue

    on Oct 22, 2024
23. mkzie2 commented on Oct 22, 2024

    

    mkzie2

    on Oct 22, 2024

    Contributor

    More actions

    @VictoriaExpensify Did it thank you
24. thesahindia commented on Oct 23, 2024

    

    thesahindia

    on Oct 23, 2024

    Member

    More actions

    Hey @VictoriaExpensify, I am eligible for the C+ compensation. I will request it on new dot. Could you please add the payment summary here? I will need it to get the money request approved.

    👍React with 👍1Reacted by Victoria O'Leary
25. VictoriaExpensify commented on Oct 24, 2024

    

    VictoriaExpensify

    on Oct 24, 2024

    Contributor

    More actions

    Payment summary:
    Contributor: @mkzie2 - Paid $250 via Upwork
    Contributor+: @thesahindia - owed $250 via NewDot
26. VictoriaExpensify

    closed this as completedon Oct 24, 2024
27. garrettmknight commented on Nov 26, 2024

    

    garrettmknight

    on Nov 26, 2024

    Contributor

    More actions

    $250 paid for @thesahindia