[$250] Distance rate-Decimals are not supported for this currency yet entering dot is allowed

@DylanDylann

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.36-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

Go to https://staging.new.expensify.com/home
Go to profile icon --workspaces --workspace
Change workspace currency to ALL
Tap more features -- distance rate
Tap on rate
Enter decimal number with dot eg : 6.4
Tap save
Tap rate again

Expected Result:

Decimals are bit supported for this currency so user must not be allowed to enter dot.

Actual Result:

Decimals are not supported for this currency yet entering dot is displayed in distance rate page.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6606435_1726567186205.screenrecorder-2024-09-17-09-24-44-25_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021836536263898090209
Upwork Job ID: 1836536263898090209
Last Price Increase: 2024-09-18
Automatic offers:

DylanDylann | Reviewer | 104120435

Issue Owner

Current Issue Owner: @DylanDylann

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@alexpensify

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-09-17 11:35:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate-Decimals are not supported for this currency yet entering dot is allowed

What is the root cause of that problem?

We are adding extra decimals prop here

App/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

Line 93 in 2190f62

extraDecimals={1}

This causes allowing one decimal to any currency.

What changes do you think we should make in order to solve the problem?

We should remove that prop or set to different value based on the decimals supported for the currency

Note : We need to check with original contributor as to why this was set to 1, based on that we can change the value.

Same can be done in this component PolicyDistanceRateEditPage
We can always find and update pages where we are using distance rate add/update functionality

Update -
After this comment

We shall pass this comment

extraDecimals={TOTAL_DECIMALS - CurrencyUtils.getCurrencyDecimals(currency)}

TOTAL_DECIMALS is constant.

Incase of TOTAL_DECIMALS = 3

case 1: CurrencyUtils.getCurrencyDecimals(currency) returns 0 then final value will be 3
case 2: CurrencyUtils.getCurrencyDecimals(currency) returns 2 then passed values will be 1, and decimals will be 3

We can update this change where we take amount input

What alternative solutions did you explore? (Optional)

Edited by proposal-police: This proposal was edited at 2024-09-17 11:38:52 UTC.

Proposal 

Please re-state the problem that we are trying to solve in this issue.

Distance rate-Decimals are not supported for this currency yet entering dot is allowed

What is the root cause of that problem?

The extraDecimals props was introduced for specific cases like tax value and distance rates.

It assumes that all currency uses 2 decimal places but this doesn't apply to all currencies.

App/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx

Lines 110 to 111 in ffeda71

    
           // The default currency uses 2 decimal places, so we substract it 
        
           extraDecimals={CONST.MAX_TAX_RATE_DECIMAL_PLACES - 2}

App/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

Line 93 in 2190f62

extraDecimals={1}

What changes do you think we should make in order to solve the problem? 

We should rename the extraDecimals prop to fixedDecimals.
In the AmountForm we should modify the line to const decimals = fixedDecimals ?? CurrencyUtils.getCurrencyDecimals(currency);

App/src/components/AmountForm.tsx

Line 87 in ffeda71

const decimals = CurrencyUtils.getCurrencyDecimals(currency) + extraDecimals;
Update all the components which uses extraDecimals props.
Then we can pass 4 or 3 to fixedDecimals props.

What alternative solutions did you explore? (Optional)

We can introduce a new prop in AmountForm to use it instead of CurrencyUtils.getCurrencyDecimals(currency) if present.

App/src/components/AmountForm.tsx

Line 87 in d009d8e

const decimals = CurrencyUtils.getCurrencyDecimals(currency) + extraDecimals;

What alternative solutions did you explore? (Optional 2)

Update to extraDecimals={getCurrencyDecimals(currency) ? 1 : 0}.
We should check all the pages which use extraDecimals prop and update like above of needed.
We can default to 3 if getCurrencyDecimals(currency) returns 0 or less than one.

Result

Job added to Upwork: https://www.upwork.com/jobs/~021836536263898090209

@DylanDylann

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@DylanDylann

@DylanDylann when you get a chance, can you review the proposals to address this Albanian currency issue? Also, I'm not sure if there are other currencies that are affected by this issue like Japanese Yen. Thanks!

Edited by proposal-police: This proposal was edited at 2024-09-25 05:28:13 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Decimals are not supported for this currency yet entering dot is allowed

What is the root cause of that problem?

We always display one extra decimal

App/src/pages/workspace/distanceRates/CreateDistanceRatePage.tsx

Line 93 in 2190f62

extraDecimals={1}

If currency is ALL the default decimal is 0 and the extra decimal is 1 --> we will display one decimal

If currency is USD the default decimal is 2 and the extra decimal is 1 --> we will display three decimal

What changes do you think we should make in order to solve the problem?

Add new prop to AmountForm Component called fixedDecimal. If fixedDecimal is valuable, we will use this value instead of CurrencyUtils.getCurrencyDecimals(currency) + extraDecimals

App/src/components/AmountForm.tsx

Line 87 in 2190f62

const decimals = CurrencyUtils.getCurrencyDecimals(currency) + extraDecimals;

In CreateDistanceRatePage PolicyDistanceRateEditPage, PolicyDistanceRateTaxReclaimableEditPage, we need to pass fixedDecimal: 4 and remove extraDecimals prop

Also need to update minimumFractionDigits: 4

App/src/libs/CurrencyUtils.ts

Line 167 in 2190f62

minimumFractionDigits: getCurrencyDecimals(currency) + 1,

Also need to update here

App/src/libs/PolicyDistanceRatesUtils.ts

Line 21 in 2190f62

    
           const rateValueRegex = RegExp(String.raw`^-?\d{0,8}([${getPermittedDecimalSeparator(decimalSeparator)}]\d{0,${CurrencyUtils.getCurrencyDecimals(currency) + 1}})?$`, 'i');

If we need to update the same thing across App (In money request flow) we also need to address some other instances (discuss futher)

@daledah

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@DylanDylann

@DylanDylann PR is ready.

Awesome, waiting for this one to go into Production.

Automation failed but this one went into production 2 days ago

Automation failed, I'll work on the payment process tomorrow.

@daledah

Payouts due: 10-07-2024

Contributor: $250 @daledah
Contributor+: $250 @DylanDylann

Upwork job is here.

@daledah

@daledah, please apply to the job above, and I can complete the payment process in Upwork. Thanks!

@alexpensify

@alexpensify Hi, can you create the offer and send to me at https://www.upwork.com/freelancers/~0138d999529f34d33f

@daledah

@daledah - I sent an offer via Upwork. Please accept, and then I can complete the payment process. Thanks!

@alexpensify

@alexpensify Accepted thx

@daledah

All set here, I've completed the payment for @daledah!

Navigation Menu

Repository navigation

[$250] Distance rate-Decimals are not supported for this currency yet entering dot is allowed #49336

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

What alternative solutions did you explore? (Optional 2)

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

36 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// The default currency uses 2 decimal places, so we substract it
	extraDecimals={CONST.MAX_TAX_RATE_DECIMAL_PLACES - 2}

[$250] Distance rate-Decimals are not supported for this currency yet entering dot is allowed #49336

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 17, 2024

IuliiaHerets commented on Sep 17, 2024

BhuvaneshPatil commented on Sep 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Krishna2323 commented on Sep 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

What alternative solutions did you explore? (Optional 2)

Result

melvin-bot commented on Sep 18, 2024

melvin-bot commented on Sep 18, 2024

alexpensify commented on Sep 18, 2024

daledah commented on Sep 20, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

36 remaining items

melvin-bot commented on Sep 25, 2024

daledah commented on Sep 26, 2024

alexpensify commented on Sep 27, 2024

alexpensify commented on Oct 2, 2024

alexpensify commented on Oct 7, 2024

alexpensify commented on Oct 8, 2024

alexpensify commented on Oct 8, 2024

daledah commented on Oct 9, 2024

alexpensify commented on Oct 10, 2024

daledah commented on Oct 11, 2024

alexpensify commented on Oct 11, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Proposal 

What changes do you think we should make in order to solve the problem? 