[HOLD for payment 2024-10-14] [$250] The intro text on private notes list stays fixed when it should scroll with the page

@dukenv0307

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.36-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726513353005399

Action Performed:

Open 1:1 chat
Click on the header
Add private notes with many lines
In private notes list page, scroll the page

Expected Result:

The intro text should be attached to the content of the page and scroll like we did with many pages

Actual Result:

The intro text is fixed when you scroll the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

bug.1.mov

Recording.553.mp4

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021835811668345209683
Upwork Job ID: 1835811668345209683
Last Price Increase: 2024-09-30
Automatic offers:

brunovjk | Reviewer | 104226815
nkdengineer | Contributor | 104226816

Issue Owner

Current Issue Owner: @lschurr

@lschurr

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Gives error saying "Please enter a valid website using lowercase characters"

What is the root cause of that problem?

We are not adding this Text here in ScrollView

App/src/pages/PrivateNotes/PrivateNotesListPage.tsx

Lines 98 to 104 in 1156e97

    
           <Text style={[styles.mb5, styles.ph5]}>{translate('privateNotes.personalNoteMessage')}</Text> 
        
           <ScrollView 
        
               contentContainerStyle={styles.flexGrow1} 
        
               bounces={false} 
        
           > 
        
               {privateNotes.map((item) => getMenuItem(item))} 
        
           </ScrollView>

What changes do you think we should make in order to solve the problem?

We can create a function like getHeaderMessage for this Text and use it inside ScrollView or simpler we can move this Text to nside ScrollView

        <ScrollView
            contentContainerStyle={styles.flexGrow1}
            bounces={false}
        >
            <Text style={[styles.mb5, styles.ph5]}>{translate('privateNotes.personalNoteMessage')}</Text>
            {privateNotes.map((item) => getMenuItem(item))}
        </ScrollView>

What alternative solutions did you explore? (Optional)

NA

Job added to Upwork: https://www.upwork.com/jobs/~021835811668345209683

@brunovjk

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

@brunovjk

Hey @brunovjk I would like to work on this issue.

@vr-varad

📣 @vr-varad! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email: varadgupta21@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01148273080994adc1

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Reviewing label has been removed, please complete the "BugZero Checklist".

@brunovjk

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: The intro text on private notes list stays fixed #50128

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

@brunovjk requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)
@dukenv0307 requires payment (Needs manual offer from BZ)

@brunovjk

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@brunovjk] The PR that introduced the bug has been identified. Link to the PR:
[@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@brunovjk] Determine if we should create a regression test for this bug.
[@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@brunovjk

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@brunovjk] The PR that introduced the bug has been identified. Link to the PR: Fix/27634: Improve private notes flow #31344
[@brunovjk] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix/27634: Improve private notes flow #31344 (comment)
[@brunovjk] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@brunovjk] Determine if we should create a regression test for this bug. Yes
[@brunovjk] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open 1:1 chat
Click on the header
Add private notes with many lines
In private notes list page, scroll the page
Verify that: The intro text should be attached to the content of the page and scroll like

Do we agree 👍 or 👎?

cc: @lschurr

@nkdengineer

Payment summary:

Contributor: $250 @nkdengineer (paid via Upwork)
Reviewer: $250 @brunovjk (paid via Upwork)

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-14] [$250] The intro text on private notes list stays fixed when it should scroll with the page #49298

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

40 remaining items

Regression Test Proposal

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Text style={[styles.mb5, styles.ph5]}>{translate('privateNotes.personalNoteMessage')}</Text>
	<ScrollView
	contentContainerStyle={styles.flexGrow1}
	bounces={false}
	>
	{privateNotes.map((item) => getMenuItem(item))}
	</ScrollView>

[HOLD for payment 2024-10-14] [$250] The intro text on private notes list stays fixed when it should scroll with the page #49298

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 16, 2024

nkdengineer commented on Sep 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Sep 16, 2024

melvin-bot commented on Sep 16, 2024

vr-varad commented on Sep 17, 2024

melvin-bot commented on Sep 17, 2024

vr-varad commented on Sep 17, 2024

melvin-bot commented on Sep 17, 2024

40 remaining items

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

melvin-bot commented on Oct 7, 2024

brunovjk commented on Oct 14, 2024

Regression Test Proposal

lschurr commented on Oct 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions