[HOLD for payment 2024-10-10] [$250] Category rules - Approver field is blank for a moment after editing category name

@stephanieelliott

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

Rules and Workflows are enabled.

Go to staging.new.expensify.com
Go to workspace settings > Categories.
Click on any category.
Click Approver.
Select any user.
Click Name.
Edit the name.

Expected Result:

Approver field will not go blank after editing category name.

Actual Result:

Approver field is blank for a moment after editing category name.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6604525_1726418206489.20240916_003344.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021837011004719364383
Upwork Job ID: 1837011004719364383
Last Price Increase: 2024-09-20
Automatic offers:

FitseTLT | Contributor | 104131224

Issue Owner

Current Issue Owner: @stephanieelliott

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@stephanieelliott

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-09-16 19:47:51 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category rules - Approver field is blank for a moment after editing category name

What is the root cause of that problem?

We use category name to get the approver here

App/src/pages/workspace/categories/CategorySettingsPage.tsx

Line 86 in 00bc167

    
           const categoryApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], categoryName);

but the policy rule takes time to get updated with the new category name

What changes do you think we should make in order to solve the problem?

We can use previous category name to get a fallback in case the approver with current category name doesn't exist

const previousCategoryName = usePrevious(categoryName);

    const approverText = useMemo(() => {
        const categoryApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], categoryName);
        const prevApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], previousCategoryName);
        return categoryApprover ?? prevApprover ?? '';
    }, [categoryName, policy?.rules?.approvalRules]);

We also have an option to use previousCategoryName policyCategories to achieve the same similar to what we did here

const prev = Object.values(policyCategories ?? {}).find((category) => category.name === categoryName);
        const prevApprover = CategoryUtils.getCategoryApprover(policy?.rules?.approvalRules ?? [], prev?.previousCategoryName);
        return categoryApprover ?? prevApprover ?? '';

BTW similar problem exists for default tax rate which depends on policy?.rules?.expenseRules here so similar fix can be done for it too.

What alternative solutions did you explore? (Optional)

The other option we have is update policy?.rules?.approvalRules optimistically in Category.renamePolicyCategory on category name change. We can iterate on the approvalRules and when we find applyWhen with value prop same as the oldname of the category we change that value with the new category name (we will also optimistically update policy?.rules?.expenseRules for the problem regarding default tax rate)

Updated

Job added to Upwork: https://www.upwork.com/jobs/~021837011004719364383

@thesahindia

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@thesahindia

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@thesahindia

Hey @thesahindia can you complete the BugZero checklist please?

@FitseTLT

Summarizing payment on this issue:

Contributor: @FitseTLT $250 via Upwork - PAID
Contributor+: @thesahindia $250 via ND payments - please request!

Upwork job is here: https://www.upwork.com/jobs/~021837011004719364383

@stephanieelliott

@stephanieelliott, @FitseTLT, @stitesExpensify, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thesahindia

Hey @thesahindia can you complete the BugZero checklist please?

^^ bump @thesahindia

Seems like it was an issue in the implementation.

Here are the steps for the test case:

Precondition: Taxes, Rules and Workflows are enabled.

Go to workspace settings > Categories
Select a category
Click "Default tax rate"
Choose any tax rate that differs from the default value
Click "Approver"
Choose a different user
Click "Name"
Change the name of the category > Save
Verify that the default tax rate doesn't change
Verify that the approver doesn't change

Thanks! Test rail case here: https://github.com/Expensify/Expensify/issues/436519

@thesahindia

$250 paid for @thesahindia

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-10] [$250] Category rules - Approver field is blank for a moment after editing category name #49293

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

24 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-10] [$250] Category rules - Approver field is blank for a moment after editing category name #49293

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 16, 2024

IuliiaHerets commented on Sep 16, 2024

FitseTLT commented on Sep 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

FitseTLT commented on Sep 16, 2024

melvin-bot commented on Sep 20, 2024

melvin-bot commented on Sep 20, 2024

24 remaining items

melvin-bot commented on Oct 3, 2024

stephanieelliott commented on Oct 11, 2024

stephanieelliott commented on Oct 11, 2024

melvin-bot commented on Oct 14, 2024

stephanieelliott commented on Oct 14, 2024

thesahindia commented on Oct 15, 2024

stephanieelliott commented on Oct 16, 2024

garrettmknight commented on Nov 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions