[HOLD for payment 2024-10-07][Search v2.3] - Dropdown title does not follow search name, "type:expense" is shown in the list

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48566
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

User has saved a few searches.

Go to staging.new.expensify.com
Go to Search.
Tap on the dropdown.
Open any saved search.
Tap on the dropdown.

Expected Result:

In Step 4, the dropdown title should follow the name of the search.
In Step 5, when viewing a saved search, there should not be "type:expense" tab in the dropdown list.

Actual Result:

In Step 4, the dropdown title shows the name "type:expense".
In Step 5, when viewing a saved search, there is a "type:expense" tab in the dropdown list.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6603107_1726282285065.ScreenRecording_09-14-2024_10-48-24_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@danieldoglas

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, the dropdown title shows the name "type:expense".
In Step 5, when viewing a saved search, there is a "type:expense" tab in the dropdown list.

What is the root cause of that problem?

If the saved search have custom name, we don't display it

App/src/pages/Search/SearchTypeMenu.tsx

Line 78 in 587698f

const title = isCannedQuery ? undefined : SearchUtils.getSearchHeaderTitle(queryJSON, personalDetails, cardList, reports, taxRates);

but we display its query json instead.

What changes do you think we should make in order to solve the problem?

When user click on any saved search, we need to add its custom name to the url, such as &name=.... Based on it, we can display the dropdown title.
First, we need to update:

App/src/pages/Search/SearchTypeMenu.tsx

Line 110 in 0c618ac

Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: item?.query ?? ''}));

                    Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: item?.query ?? '', name: item.name}));

And modify the ROUTES:

App/src/ROUTES.ts

Line 38 in 0c618ac

    
           getRoute: ({query}: {query: SearchQueryString}) => `search?q=${encodeURIComponent(query)}` as const,

        getRoute: ({query, name}: {query: SearchQueryString; name: string}) => `search?q=${encodeURIComponent(query)}${name ? `&name=${name}` : ''}` as const,

Finally, update:

App/src/pages/Search/SearchTypeMenu.tsx

Line 186 in 0c618ac

    
           const title = isCannedQuery ? undefined : SearchUtils.getSearchHeaderTitle(queryJSON, personalDetails, cardList, reports, taxRates);

        const title = searchName ?? (isCannedQuery ? undefined : SearchUtils.getSearchHeaderTitle(queryJSON, personalDetails, cardList, reports, taxRates));

with the searchName comes from url.

What alternative solutions did you explore? (Optional)

This is known and will be addressed in a follow up.

@dominictb

Payment summary:

Contributor: $250 @dominictb via Upwork
Reviewer: $250 @brunovjk via Upwork

@brunovjk

Offer sent to @brunovjk. @dominictb can you remind me of your Upwork profile?

Accepted :D

@JmillsExpensify

can you remind me of your Upwork profile?

@JmillsExpensify It's https://www.upwork.com/freelancers/~01f70bed1934fd35d5

@JmillsExpensify

@JmillsExpensify, @lakchote, @luacmartins, @brunovjk, @dominictb Eep! 4 days overdue now. Issues have feelings too...

Offer sent

Offer accepted

All contributors paid out!

@JmillsExpensify

@JmillsExpensify @lakchote @luacmartins Be sure to fill out the Contact List!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-07][Search v2.3] - Dropdown title does not follow search name, "type:expense" is shown in the list #49208

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

32 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-07][Search v2.3] - Dropdown title does not follow search name, "type:expense" is shown in the list #49208

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Sep 14, 2024

melvin-bot commented on Sep 14, 2024

github-actions commented on Sep 14, 2024

dominictb commented on Sep 15, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

luacmartins commented on Sep 15, 2024

32 remaining items

JmillsExpensify commented on Oct 23, 2024

JmillsExpensify commented on Oct 23, 2024

brunovjk commented on Oct 23, 2024

dominictb commented on Oct 28, 2024

melvin-bot commented on Oct 29, 2024

JmillsExpensify commented on Oct 30, 2024

dominictb commented on Oct 30, 2024

JmillsExpensify commented on Oct 30, 2024

melvin-bot commented on Oct 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions