Skip to content

[HOLD for payment 2024-11-29] [Held] [$250] Invoices - Workspace settings can be opened from "workspace" link when workspace is deleted #49093

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User B has no workspace.
  1. Go to staging.new.expensify.com
  2. {User A] Send an invoice to User B.
  3. [User B] Pay the invoice using Pay as a business option.
  4. [User B] Delete the workspace.
  5. {User B] Go to invoice chat.
  6. [User B] Click on the "workspace" link in Expensify message.

Expected Result:

The link should lead to not here page because workspace is deleted.

Actual Result:

The link can open workspace settings page and Members tab leads to not here page.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6601039_1726148441534.20240912_213050.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834598579747458653
  • Upwork Job ID: 1834598579747458653
  • Last Price Increase: 2024-09-13
  • Automatic offers:
    • ishpaul777 | Contributor | 104008088
    • gijoe0295 | Contributor | 104027162
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Sep 12, 2024
  2. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Sep 12, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-bills

  4. removed
    DeployBlockerIndicates it should block deploying the API
    on Sep 12, 2024
  5. iwiznia commented on Sep 12, 2024

    @iwiznia
    Contributor
  6. melvin-bot commented on Sep 12, 2024

    @melvin-bot

    Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. github-actions commented on Sep 12, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 71 remaining items

  9. ishpaul777 commented on Nov 30, 2024

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/38488/files#r1864457951

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: not required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Not required because reproduction steps are far fetched, not a core or even usual flow, Real user rarely could have encountered it, One time issue Now its fixed

  10. melvin-bot commented on Dec 2, 2024

    @melvin-bot

    @srikarparsi, @joekaufmanexpensify, @ishpaul777, @gijoe0295 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    Just back from OOO. Will handle remaining steps today!

  12. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    Checklist is all set. We're good to pay.

  13. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    We need to pay:

  14. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    @gijoe0295 $250 sent and contract ended!

  15. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    @ishpaul777 $250 sent and contract ended!

  16. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    Upwork job closed

  17. joekaufmanexpensify commented on Dec 2, 2024

    @joekaufmanexpensify
    Contributor

    All set, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions