Repository navigation
[HOLD for payment 2024-11-29] [Held] [$250] Invoices - Workspace settings can be opened from "workspace" link when workspace is deleted #49093
Description
Activity
- addedBugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Sep 12, 2024 Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.We think that this bug might be related to #vip-bills
- removedDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Sep 12, 2024 Removed blocker, see https://expensify.slack.com/archives/C9YU7BX5M/p1726158576447559
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deployment
on Sep 12, 2024 Triggered auto assignment to @srikarparsi (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commented
on Sep 12, 2024 on Sep 12, 2024 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
71 remaining items
BugZero Checklist:
- [Contributor] Classify the bug:
Bug classification
Source of bug:
- 1a. Result of the original design (eg. a case wasn't considered)
- 1b. Mistake during implementation
- 1c. Backend bug
- 1z. Other:
Where bug was reported:
- 2a. Reported on production
- 2b. Reported on staging (deploy blocker)
- 2c. Reported on both staging and production
- 2d. Reported on a PR
- 2z. Other:
Who reported the bug:
- 3a. Expensify user
- 3b. Expensify employee
- 3c. Contributor
- 3d. QA
- 3z. Other:
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/38488/files#r1864457951
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not required
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Not required because reproduction steps are far fetched, not a core or even usual flow, Real user rarely could have encountered it, One time issue Now its fixed
@srikarparsi, @joekaufmanexpensify, @ishpaul777, @gijoe0295 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actionsJust back from OOO. Will handle remaining steps today!
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actionsChecklist is all set. We're good to pay.
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actionsWe need to pay:
- @gijoe0295 $250 for PR via Upwork.
- @ishpaul777 $250 for C+ via Upwork.
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actions@gijoe0295 $250 sent and contract ended!
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actions@ishpaul777 $250 sent and contract ended!
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actionsUpwork job closed
joekaufmanexpensify commented
on Dec 2, 2024 ContributorMore actionsAll set, thanks everyone!
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.33-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: #48275
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
Expected Result:
The link should lead to not here page because workspace is deleted.
Actual Result:
The link can open workspace settings page and Members tab leads to not here page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6601039_1726148441534.20240912_213050.1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @joekaufmanexpensify