[Workspace Feeds] unable to change card limit to $0

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Reproducible in staging?: Y
Email or phone of affected tester (no customers):

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725978148730949

Action Performed:

1. Add account to workspaceFeeds beta
2. Sign in with test account
3. Select Manage my team’s expenses
4. Enter any business name / personal name
5. Navigate to the workspace editor of the newly created workspace
6. Navigate to More features tab
7. Toggle on the feature
8. Navigate to the Expensify Card page
9. Select Issue new card
10. Follow the steps for an OPEN bank account (option 3) of this SO, and exit the onboarding flow at the requestor information section
    Select Finish setup and continue through the VBBA flow
    Finish the setup process
11. Issue an Expensify Card with >$0 limit
12. Select the newly issued card in the cards list
13. Change the limit to $0

Expected Result:

See a modal with the following copy:

Header: “change card limit”
Body: “If you change this card’s limit to $[new limit], new transactions will be declined until next month.”
Buttons: “Change limit” and “Cancel”

Actual Result:

Unable to change to $0

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2024-09-10_10-19-36.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kevinksullivan]

CC @mountiny

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

unable to change card limit to $0

What is the root cause of that problem?

App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitPage.tsx

Lines 91 to 93 in c4c46fe

	if (!Number(values.limit) || !Number.isInteger(Number(values.limit))) {
	errors.limit = translate('iou.error.invalidAmount');
	}

The validate function return error because values.limit = 0

What changes do you think we should make in order to solve the problem?

App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitPage.tsx

Lines 91 to 93 in c4c46fe

	if (!Number(values.limit) || !Number.isInteger(Number(values.limit))) {
	errors.limit = translate('iou.error.invalidAmount');
	}

Remove !Number(values.limit) condition

What alternative solutions did you explore? (Optional)