Skip to content

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] [$250] [Search v2.2] Reload the page and highlight the newly added expense when adding a new expense from the search page #48716

Closed
Closed
[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] [$250] [Search v2.2] Reload the page and highlight the newly added expense when adding a new expense from the search page#48716
Assignees
trjExpensifyluacmartinsikevin127ishpaul777dubielzyk-expensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Description

@trjExpensify
trjExpensify
opened on Sep 6, 2024

Follow-up to here.

Two items to add:

  1. When the new expense is added to the search page, trigger a reload of the page so it can appear in the table.

I think we might need to just trigger a reload of the page given the existing filters may or may not show the new transation.

  1. Highlight the newly added expense row in the table when it appears

For this, we were thinking it could borrow from the workspace settings when you enable a new feature in More features, and the row gets highlighted in the LHN briefly.

Once we've done that, we'll add this regression test for Applause:

  1. Switch to the search page tab
  2. Click the global create button > submit expense > submit an expense
  3. Verify you remain on the search page
  4. Verify the search page reloads and the expense appears in the table
  5. Verify the newly added expense row is briefly highlighted to draw attention to it

CC: @Expensify/design @luacmartins @adamgrzybowski @ikevin127

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021838256578746413929
  • Upwork Job ID: 1838256578746413929
  • Last Price Increase: 2024-09-23
  • Automatic offers:
    • ikevin127 | Reviewer | 104270100
    • ishpaul777 | Contributor | 104270102
Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. trjExpensify
    added
    DailyKSv2
    PlanningChanges still in the thought process
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 6, 2024
  2. trjExpensify
    self-assigned this
    on Sep 6, 2024
  3. trjExpensify
    added this to #expensify-bugson Sep 6, 2024

  4. melvin-bot commented on Sep 6, 2024

    @melvin-bot
    melvin-botBot
    on Sep 6, 2024 – with Melvin Bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  5. trjExpensify
    moved this to Release 3: Fall 2024 (Nov) in #expensify-bugson Sep 6, 2024
  6. trjExpensify
    moved this from Release 3: Fall 2024 (Nov) to Polish in #expensify-bugson Sep 6, 2024
  7. trjExpensify
    added
    Design
    on Sep 6, 2024
  8. melvin-bot
    assigned
    dubielzyk-expensify
    on Sep 6, 2024

  9. melvin-bot commented on Sep 6, 2024

    @melvin-bot
    melvin-botBot
    on Sep 6, 2024 – with Melvin Bot

    Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

  10. trjExpensify commented on Sep 6, 2024

    @trjExpensify
    trjExpensify
    on Sep 6, 2024
    ContributorAuthor

    Can we get a mock of the row highlighted to include here, please? Thanks!

  11. ikevin127 commented on Sep 7, 2024

    @ikevin127
    ikevin127
    on Sep 7, 2024
    Contributor

    ♻️ Will look into this tomorrow, the plan being to come up with a proposal and some videos for the design team to review 👍

  12. melvin-bot
    added
    Overdue
    on Sep 9, 2024

  13. dubielzyk-expensify commented on Sep 9, 2024

    @dubielzyk-expensify
    dubielzyk-expensify
    on Sep 9, 2024
    Contributor

    Animation 1: Just color fade

    CleanShot.2024-09-09.at.20.06.20.mp4

    Animation 2: Slide and color fade

    CleanShot.2024-09-09.at.20.06.36.mp4

    Animation 3: Color fade and stay

    CleanShot.2024-09-09.at.20.10.45.mp4

    No animation: Use highlight state color

    We do use a highlight color on chats but I'm personally not a huge fan of this due to how muddy it looks. If we apply it here I don't think it looks great:
    image

    cc @Expensify/design team for thoughts

  14. 52 remaining items

  15. melvin-bot commented on Oct 3, 2024

    @melvin-bot
    melvin-botBot
    on Oct 3, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  16. ishpaul777 commented on Oct 4, 2024

    @ishpaul777
    ishpaul777
    on Oct 4, 2024
    Contributor

    👋 Please assign me here i reviewed #49192

  17. trjExpensify
    assigned
    ishpaul777
    on Oct 4, 2024

  18. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  19. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  20. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Oct 4, 2024
  21. melvin-bot
    changed the title [-][HOLD for payment 2024-10-10] [$250] [Search v2.2] Reload the page and highlight the newly added expense when adding a new expense from the search page[/-] [+][HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] [$250] [Search v2.2] Reload the page and highlight the newly added expense when adding a new expense from the search page[/+] on Oct 4, 2024

  22. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-11. 🎊

    For reference, here are some details about the assignees on this issue:

  23. melvin-bot commented on Oct 4, 2024

    @melvin-bot
    melvin-botBot
    on Oct 4, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127 / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127 / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127 / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127 / @ishpaul777] Determine if we should create a regression test for this bug.
    • [@ikevin127 / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  24. ikevin127 commented on Oct 4, 2024

    @ikevin127
    ikevin127
    on Oct 4, 2024
    Contributor

    Regression Test Proposal

    1. Switch to the Search page tab.
    2. Click the global create button (FAB) > Submit expense > Submit an expense.
    3. Verify you remain on the Search page.
    4. Verify that the newly added expense appears in the table and the row is briefly highlighted to draw attention to it.

    Do we agree 👍 or 👎.

  25. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 9, 2024

  26. trjExpensify commented on Oct 11, 2024

    @trjExpensify
    trjExpensify
    on Oct 11, 2024
    ContributorAuthor

    Regression test created. Payment summary as follows:

    Paid, closing!

  27. trjExpensify
    closed this as completedon Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2DesignExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions