Repository navigation
[HOLD for payment 2024-11-21] [$250] iOS Invoices - Blank area under composer after returning from workspace page #48677
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48014
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Precondition:
- User has sent invoice to the receiver and receiver has paid the invoice.
- Launch New Expensify app.
- Open invoice chat as the invoice sender.
- Tap on the invoice preview.
- Tap on the composer to bring up keyboard.
- Tap Add bank account.
- Return to the invoice report.
Expected Result:
There will not be a blank area under the composer if keyboard is not up.
Actual Result:
There is a blank area under the composer when keyboard is not up after returning from workspace page.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6594706_1725576434622.ScreenRecording_09-06-2024_06-42-27_1.1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021831977574854649069
- Upwork Job ID: 1831977574854649069
- Last Price Increase: 2024-10-17
- Automatic offers:
- QichenZhu | Contributor | 104516887
Activity
melvin-bot commentedon Sep 6, 2024
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Sep 6, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Sep 6, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mjasikowski commentedon Sep 6, 2024
on it
mjasikowski commentedon Sep 6, 2024
per conversation with @mountiny, demoting this one since it's minor UI issue which can be worked around (the user can tap on the composer field to bring the keyboard back up) and this occurs on a single platform only
92 remaining items
melvin-bot commentedon Nov 14, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 14, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-21. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 14, 2024
@fedirjh @muttmuure @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
muttmuure commentedon Nov 22, 2024
$250 - @fedirjh C+
$250 @QichenZhu C
fedirjh commentedon Nov 22, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A , This is an upstream bug : Fix KeyboardAvoidingView not aware of the keyboard closing after it is unmounted react/react-native#46952
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Nov 26, 2024
@mjasikowski, @fedirjh, @muttmuure, @QichenZhu Whoops! This issue is 2 days overdue. Let's get this updated quick!
garrettmknight commentedon Dec 10, 2024
$250 approved for @fedirjh