Repository navigation
[$250] Expense - Unable to create a new line in description field with SHIFT+ENTER #48061
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.25-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to chat.
- Click + > Submit expense > Manual.
- Enter amount > Next.
- Click Description.
- Enter some text, then press SHIFT+ENTER (enter key for mweb).
Expected Result:
A new line will be created with SHIFT+ENTER.
Actual Result:
A new line is not created with SHIFT+ENTER. The description is saved instead.
This issue happens in IOU, task and room description.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6583767_1724725007695.20240827_101239.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0140f764621c9cb74a
- Upwork Job ID: 1828427517631808725
- Last Price Increase: 2024-08-27
Activity
melvin-bot commentedon Aug 27, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Aug 27, 2024
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.IuliiaHerets commentedon Aug 27, 2024
We think that this bug might be related to #wave-collect - Release 1
github-actions commentedon Aug 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
9 remaining items
s77rt commentedon Aug 27, 2024
@bernhardoj Thanks for the proposal. I think this one should be fixed by the PR author given it's a new regression #47705. cc @Krishna2323 @ZhenjaHorbach
ZhenjaHorbach commentedon Aug 27, 2024
Oh
Yeah
This is ours !
@Krishna2323
Could you raise the PR please?
Krishna2323 commentedon Aug 27, 2024
@ZhenjaHorbach, will raise the PR within an hour.
bernhardoj commentedon Aug 28, 2024
Since the help wanted label is added, I think we can apply my solution instead of reintroducing deprecated ACCESSIBILITY_ROLE constant and also applying additional changes from my proposal.
s77rt commentedon Aug 28, 2024
@bernhardoj
The
textboxis not a valid role value according to this listThis makes sense but it won't fix the problem as if we do that now the role will be
presentationand the enter shortcut will still not be disabledbernhardoj commentedon Aug 28, 2024
Looks like it's different between RN and RN-web since RN-web supports all ARIA roles. Maybe on native, it's not explicitly needed to set the role to an input, similar to web where it's recommended to use input without any role.
Yes, that's why I suggest this.
s77rt commentedon Aug 28, 2024
@bernhardoj If we remove the role prop from all input, including single-line inputs, then the enter key press won't be captured but it's needed in that case.
melvin-bot commentedon Sep 20, 2024
This issue has not been updated in over 15 days. @s77rt, @Gonals, @kadiealexander eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
s77rt commentedon Sep 20, 2024
@kadiealexander @Gonals Let's close this. Fixed on #48128