Skip to content

[Awaiting Payment] [$250] Update Wallet and Generic Folder empty state to use lottie animations #48013

Closed

Description

@shawnborton

We have some empty states in our product that are currently static, and we want to update them to have looping Lottie animations.

The first place is the Wallet empty state:
CleanShot 2024-08-26 at 11 55 25@2x

And the other place is anywhere we show the folder empty state, like Search or Workspaces > Tags, Workspaces > Report fields, etc:
CleanShot 2024-08-26 at 11 58 43@2x

Here are the lottie files needed:

SettingsWallet-082324-1

GenericEmptyState-082324-1

cc @roryabraham @Expensify/design @luacmartins for visibility

@trjExpensify - I wonder if this is considered #wave-control polish or something?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0164ffd5b6f9684066
  • Upwork Job ID: 1828144309254029734
  • Last Price Increase: 2024-08-26
  • Automatic offers:
    • Krishna2323 | Contributor | 103690909
Issue OwnerCurrent Issue Owner: @anmurali

Activity

  1. self-assigned this
    on Aug 26, 2024
  2. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  3. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Aug 26, 2024

    @melvin-bot

    Current assignee @shawnborton is eligible for the NewFeature assigner, not assigning anyone new.

  5. melvin-bot commented on Aug 26, 2024

    @melvin-bot
  6. Krishna2323 commented on Aug 26, 2024

    @Krishna2323
    Contributor

    Edited by proposal-police: This proposal was edited at 2024-08-26 17:21:01 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Update Wallet and Generic Folder empty state to use lottie animations

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    We need to add the animations in this file and update the props below:

    headerMedia: Illustrations.EmptyState,

    illustration={Illustrations.BigVault}

    headerMedia={Illustrations.EmptyState}

    headerMedia={Illustrations.EmptyState}

    EmptyStateExpenses

    icon={Illustrations.EmptyStateExpenses}

    headerMedia={Illustrations.EmptyStateExpenses}

    headerMedia={Illustrations.EmptyStateExpenses}

    We might also need to update several other props like headerMediaType

    headerMediaType={CONST.EMPTY_STATE_MEDIA.ILLUSTRATION}

    • In IOURequestStepCategory we can use EmptyStateComponent instead of WorkspaceEmptyStateSection, or we can update WorkspaceEmptyStateSection to use EmptyStateComponent, we also need to update in NetSuiteImportCustomFieldPage.
      <WorkspaceEmptyStateSection
      shouldStyleAsCard={false}
      icon={Illustrations.EmptyStateExpenses}
      title={translate('workspace.categories.emptyCategories.title')}
      subtitle={translate('workspace.categories.emptyCategories.subtitle')}
      containerStyle={[styles.flex1, styles.justifyContentCenter]}
      />

    What alternative solutions did you explore? (Optional)


    Result

    Monosnap.screencast.2024-08-26.23-35-46.mp4
  7. Krishna2323 commented on Aug 26, 2024

    @Krishna2323
    Contributor

    Proposal Updated

    • Added result video
  8. roryabraham commented on Aug 26, 2024

    @roryabraham
    Contributor

    @Krishna2323 I think you missed a few spots where this change is needed, such as here. Please enumerate all the locations in the app where Illustrations.EmptyState is used.

  9. Krishna2323 commented on Aug 26, 2024

    @Krishna2323
    Contributor

    @roryabraham thanks, proposal updated, we also need to update in WorkspaceCategoriesPage & WorkspaceTagsPage.

  10. shawnborton commented on Aug 26, 2024

    @shawnborton
    ContributorAuthor

    There's also a spot when creating reportFields that we have an empty list view as well.

  11. 32 remaining items

  12. changed the title [-][$250] Update Wallet and Generic Folder empty state to use lottie animations[/-] [+][Awaiting Payment] [$250] Update Wallet and Generic Folder empty state to use lottie animations[/+] on Oct 4, 2024
  13. melvin-bot commented on Oct 8, 2024

    @melvin-bot

    @shawnborton, @anmurali, @hungvu193, @roryabraham, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. anmurali commented on Oct 9, 2024

    @anmurali

    paid @Krishna2323
    @hungvu193 sent you an offer

  15. hungvu193 commented on Oct 9, 2024

    @hungvu193
    Contributor

    Thanks. I've just accepted!

  16. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    @shawnborton, @anmurali, @hungvu193, @roryabraham, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. anmurali commented on Oct 16, 2024

    @anmurali

    Paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions