You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting Payment] [$250] Update Wallet and Generic Folder empty state to use lottie animations #48013
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
In IOURequestStepCategory we can use EmptyStateComponent instead of WorkspaceEmptyStateSection, or we can update WorkspaceEmptyStateSection to use EmptyStateComponent, we also need to update in NetSuiteImportCustomFieldPage.
@Krishna2323 I think you missed a few spots where this change is needed, such as here. Please enumerate all the locations in the app where Illustrations.EmptyState is used.
changed the title [-][$250] Update Wallet and Generic Folder empty state to use lottie animations[/-][+][Awaiting Payment] [$250] Update Wallet and Generic Folder empty state to use lottie animations[/+]on Oct 4, 2024
Activity
melvin-bot commentedon Aug 26, 2024
Triggered auto assignment to @anmurali (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.melvin-bot commentedon Aug 26, 2024
melvin-bot commentedon Aug 26, 2024
Current assignee @shawnborton is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Aug 26, 2024
Krishna2323 commentedon Aug 26, 2024
Edited by proposal-police: This proposal was edited at 2024-08-26 17:21:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Update Wallet and Generic Folder empty state to use lottie animations
What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
We need to add the animations in this file and update the props below:
App/src/pages/Search/EmptySearchView.tsx
Line 41 in 61aa0af
App/src/pages/settings/Wallet/WalletPage/WalletPage.tsx
Line 375 in 61aa0af
App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx
Line 349 in 0fd1de0
App/src/pages/workspace/tags/WorkspaceTagsPage.tsx
Line 362 in 0fd1de0
EmptyStateExpenses
App/src/pages/iou/request/step/IOURequestStepCategory.tsx
Line 174 in 0fd1de0
App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx
Line 316 in 0fd1de0
App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
Line 292 in 0fd1de0
We might also need to update several other props like
headerMediaTypeApp/src/pages/Search/EmptySearchView.tsx
Line 55 in 61aa0af
IOURequestStepCategorywe can useEmptyStateComponentinstead ofWorkspaceEmptyStateSection, or we can updateWorkspaceEmptyStateSectionto useEmptyStateComponent, we also need to update inNetSuiteImportCustomFieldPage.App/src/pages/iou/request/step/IOURequestStepCategory.tsx
Lines 172 to 178 in 0fd1de0
What alternative solutions did you explore? (Optional)
Result
Monosnap.screencast.2024-08-26.23-35-46.mp4
Krishna2323 commentedon Aug 26, 2024
Proposal Updated
roryabraham commentedon Aug 26, 2024
@Krishna2323 I think you missed a few spots where this change is needed, such as here. Please enumerate all the locations in the app where
Illustrations.EmptyStateis used.Krishna2323 commentedon Aug 26, 2024
@roryabraham thanks, proposal updated, we also need to update in
WorkspaceCategoriesPage&WorkspaceTagsPage.shawnborton commentedon Aug 26, 2024
There's also a spot when creating reportFields that we have an empty list view as well.
32 remaining items
[-][$250] Update Wallet and Generic Folder empty state to use lottie animations[/-][+][Awaiting Payment] [$250] Update Wallet and Generic Folder empty state to use lottie animations[/+]melvin-bot commentedon Oct 8, 2024
@shawnborton, @anmurali, @hungvu193, @roryabraham, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
anmurali commentedon Oct 9, 2024
paid @Krishna2323
@hungvu193 sent you an offer
hungvu193 commentedon Oct 9, 2024
Thanks. I've just accepted!
melvin-bot commentedon Oct 14, 2024
@shawnborton, @anmurali, @hungvu193, @roryabraham, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!
anmurali commentedon Oct 16, 2024
Paid.