[$250] Invoice - Category field does not show up on confirmation page after relogin

@rayane-djouah

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4888644
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Create two new workspaces
Log out and log in
Go to FAB > Send invoice > Proceed to confirmation page
Click Show more
Note that Category field is present
Click Send from and select the second workspace
Click Show more and note that Category field is absent
Go to workspace settings of the second workspace in Step 8 > Categories
Repeat Step 4 to 5 with the second workspace in Step 8
Note that Category field is present after visiting Categories settings page

Expected Result:

In Step 8, after relogin, the Category field should be present on the confirmation page when the sender is the second workspace

Actual Result:

In Step 8, after relogin, the Category field is absent on the confirmation page when the sender is the second workspace.
In Step 11, the Category field only reappears after Categories settings page is visited

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6580334_1724419504479.20240823_212348.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831332316106024173
Upwork Job ID: 1831332316106024173
Last Price Increase: 2024-09-11
Automatic offers:

rayane-djouah | Reviewer | 103920522
Nodebrute | Contributor | 103920525

Issue Owner

Current Issue Owner: @rayane-djouah

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@JmillsExpensify

@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-08-23 15:37:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Category field does not show up on confirmation page after relogin

What is the root cause of that problem?

When we log in using the openApp API call, we only receive the categories, tags, and other details for the first policy. As a result, if we select any other policy, the data is not present in Onyx, which causes the category field to be missing. However, when submitting an expense within a policy, we call openDraftWorkspaceRequest, which retrieves all data related to that policy. This behavior does not apply when sending invoices. This condition is not true for invoice types policyExpenseChat?.policyID

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Lines 162 to 166 in eb5f55b

    
           useEffect(() => { 
        
               const policyExpenseChat = participants?.find((participant) => participant.isPolicyExpenseChat); 
        
               if (policyExpenseChat?.policyID && policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) { 
        
                   openDraftWorkspaceRequest(policyExpenseChat.policyID); 
        
               }

What changes do you think we should make in order to solve the problem?

For invoice-type transactions, we should also call this API to retrieve the necessary data. We can obtain the policy ID using various methods.

In case of invoices we can use the check isSender and get the policyID from that participant and then we can call openDraftWorkspaceRequest.

What alternative solutions did you explore? (Optional)

We can also get the policyID from policy?.id
or
In the transaction participants data for invoice, we should also include the isPolicyExpenseChat field.

@JmillsExpensify

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@davidcardoza

I'll open it up to proposals and I've filled this bug in the invoicing initiative. cc @davidcardoza

@JmillsExpensify

@JmillsExpensify No C+ is assigned. Can you add the labels again?

PR on production

@JmillsExpensify

Note

The production deploy automation failed: This should be on [HOLD for Payment 2024-10-07] according to #49855 production deploy checklist, confirmed in #49142 (comment)

cc @JmillsExpensify

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

^ False positive. #50246 (comment)

@JmillsExpensify

BugZero Checklist

The PR that introduced the bug has been identified. Link to the PR: Implement Send Invoice flow from Global Create #40015
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40015/files#r1789251515
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Create two new workspaces.
Log out and then log back in.
Ensure you are online.
Click on the FAB, select "Send Invoice," and proceed to the confirmation page.
Click on "Send from" and select an other workspace.
On the confirmation page, click "Show More."
Verify that the category field is present.

Do we agree 👍 or 👎

cc @JmillsExpensify

@Nodebrute

Payment summary:

Contributor: $250 @Nodebrute
Reviewer: $250 @rayane-djouah

All Contributors paid via Upwork.

@JmillsExpensify

@JmillsExpensify Can we close this issue?

@stitesExpensify

@stitesExpensify @JmillsExpensify I think we can close this issue

Not yet, let me add the regression test request first and then I can close.

All done.

Navigation Menu

Repository navigation

[$250] Invoice - Category field does not show up on confirmation page after relogin #47922

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

35 remaining items

BugZero Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	useEffect(() => {
	const policyExpenseChat = participants?.find((participant) => participant.isPolicyExpenseChat);
	if (policyExpenseChat?.policyID && policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD) {
	openDraftWorkspaceRequest(policyExpenseChat.policyID);
	}

[$250] Invoice - Category field does not show up on confirmation page after relogin #47922

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 23, 2024

lanitochka17 commented on Aug 23, 2024

Nodebrute commented on Aug 23, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 26, 2024

JmillsExpensify commented on Aug 28, 2024

Nodebrute commented on Aug 28, 2024

35 remaining items

rayane-d commented on Oct 2, 2024

rayane-d commented on Oct 2, 2024

melvin-bot commented on Oct 4, 2024

rayane-d commented on Oct 4, 2024

rayane-d commented on Oct 6, 2024

BugZero Checklist

JmillsExpensify commented on Oct 7, 2024

JmillsExpensify commented on Oct 7, 2024

rayane-d commented on Oct 15, 2024

rayane-d commented on Oct 18, 2024

JmillsExpensify commented on Oct 21, 2024

JmillsExpensify commented on Oct 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions