[HOLD for payment 2024-10-04][$250] Dupe detect - Invited user is not able to see the receipt placeholder on the confirmation page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.24-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a workspace.
3. Submit two same expenses to the workspace chat.
4. Go to transaction thread (any).
5. Click Review duplicates > Keep this one (any).
6. Proceed to confirmation page.
7. Note that there is a receipt placeholder on the confirmation page.
8. As another user, invite the current user to a workspace.
9. As the invited user, go to workspace chat.
10. Repeat Step 3 to 6.
11. Notet hat there is no receipt placeholder on the confirmation page.

Expected Result:

In Step 11, the invited user should be able to see the receipt placeholder on the confirmation page.

Actual Result:

In Step 11, the invited user is unable to see the receipt placeholder on the confirmation page.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6580073_1724396847575.20240823_145830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01741cd4c1fe7a4231
• Upwork Job ID: 1828132802801480968
• Last Price Increase: 2024-08-26

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 11, the invited user is unable to see the receipt placeholder on the confirmation page.

What is the root cause of that problem?

when canEditReceipt=false, we only show Receipt empty state to admin and Approver in here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 382 to 383 in 259a9b7

	const shouldShowReceiptEmptyState =
	isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover) && (canEditReceipt || ReportUtils.isPaidGroupPolicy(report));

What changes do you think we should make in order to solve the problem?

We should show Receipt empty state to requestor too like we did here

1. Calculate isRequestor based on currentUserPersonalDetails and parentReportAction

    const currentUserPersonalDetails = useCurrentUserPersonalDetails();
    const isRequestor = currentUserPersonalDetails.accountID === parentReportAction?.actorAccountID;

2. Update logic shouldShowReceiptEmptyState here

    const shouldShowReceiptEmptyState =
        isReceiptAllowed && !hasReceipt && !isApproved && !isSettled && (canEditReceipt || isAdmin || isApprover || isRequestor) && (canEditReceipt || ReportUtils.isPaidGroupPolicy(report));

What alternative solutions did you explore? (Optional)