[HOLD for payment 2024-10-10] [$250] connect to Quickbooks Dekstop on OldDot, the admin room in newdot shows incomplete system messages

@dubielzyk-expensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.23-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dubielzyk-expensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724242725049269

Action Performed:

Login with same account in OD and ND
Go to workspace in OD
Connect to Quickbooks Dekstop
Go to # admin room of the same workspace

Expected Result:

There shouldn't be any incomplete message

Actual Result:

“removed the connection to message appears

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021833242408324478296
Upwork Job ID: 1833242408324478296
Last Price Increase: 2024-09-23
Automatic offers:

DylanDylann | Contributor | 104119799

Issue Owner

Current Issue Owner: @dylanexpensify

Edited by proposal-police: This proposal was edited at 2024-08-22 02:59:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

“removed the connection to message appears

What is the root cause of that problem?

We don't have a specific logic to display POLICYCHANGELOG_DELETE_INTEGRATION, so it displays the message[0].text, which is removed the connection to.

What changes do you think we should make in order to solve the problem?

We can create a logic to handle this type of message in:

App/src/pages/home/report/ReportActionItem.tsx

Line 676 in ad7c1d5

} else {

        } else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_INTEGRATION) {
            children = (
                <ReportActionItemBasicMessage
                    message={`Removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[ReportActionsUtils.getOriginalMessage(action).connectionName]}`}
                />
            );

Same logic should be applied to LHN in here:

App/src/libs/SidebarUtils.ts

Line 438 in ad7c1d5

} else {

        } else if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.POLICY_CHANGE_LOG.DELETE_INTEGRATION) {
            result.alternateText = `Removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[ReportActionsUtils.getOriginalMessage(lastAction).connectionName]}`;
        }

and

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 473 in ad7c1d5

} else if (content) {

The text to display can be updated later based on design.

What alternative solutions did you explore? (Optional)

Huh... This is 4 days overdue. Who can take care of this?

Still overdue 6 days?! Let's take care of this!

10 days overdue. Is anyone even seeing these? Hello?

@dylanexpensify

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bfitzexpensify

@bfitzexpensify confirming this is a bug, yeah?

Yeah, I agree with the expected vs actual result differing, and this therefore being a bug

@dylanexpensify

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Coming up!

@daledah

Payment summary:

Contributor: @daledah $250
Contributor+: @DylanDylann $250

Please apply/request!

@daledah

@daledah please apply!

@DylanDylann

@DylanDylann paid!

@dylanexpensify

@dylanexpensify applied

@daledah

@daledah offer sent!

@DylanDylann

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: *This change seem like a new feature, not a bug
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Login with the same account in OD and ND
Go to workspace in OD
Connect to Quickbooks Dekstop
In OD, disconnect from Quickbooks Desktop
In ND, navigate to WS #admins chat
Verify that: The Report Action Item, Sidebar Text shows the correct message
Right click on the message, click "Copy to Clipboard" and paste.
Verify that: Pasted text shows the correct message

Do we agree 👍 or 👎

Done!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-10] [$250] connect to Quickbooks Dekstop on OldDot, the admin room in newdot shows incomplete system messages #47830

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

52 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-10] [$250] connect to Quickbooks Dekstop on OldDot, the admin room in newdot shows incomplete system messages #47830

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

daledah commented on Aug 22, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 27, 2024

melvin-bot commented on Aug 29, 2024

melvin-bot commented on Sep 2, 2024

melvin-bot commented on Sep 3, 2024

dylanexpensify commented on Sep 4, 2024

bfitzexpensify commented on Sep 4, 2024

melvin-bot commented on Sep 5, 2024

52 remaining items

dylanexpensify commented on Oct 4, 2024

dylanexpensify commented on Oct 7, 2024

dylanexpensify commented on Oct 14, 2024

dylanexpensify commented on Oct 14, 2024

dylanexpensify commented on Oct 14, 2024

daledah commented on Oct 14, 2024

dylanexpensify commented on Oct 16, 2024

DylanDylann commented on Oct 17, 2024

dylanexpensify commented on Oct 17, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions