[HOLD for payment 2024-11-18] [$500] [Dupe detection] Tax code review step shows empty option when workspace does not have tax rate

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Workspace A has tax rates.
• Workspace B does not have Taxes feature (disabled)

1. Go to staging.new.expensify.com
2. Go to workspace chat (workspace A)
3. Submit an expense with tax rate
4. Go to workspace chat (workspace B)
5. Submit the same expense as Step 3 but without tax rate
6. Submit another expense (any amount) to workspace chat (workspace B)
7. Open transaction thread of the expense submitted in Step 5
8. Click Review duplicates
9. Click Keep this one (any)
10. Proceed to Tax code review page

Expected Result:

Tax code review page will not have blank option

Actual Result:

Tax code review page shows blank option

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6577995_1724235905888.bandicam_2024-08-21_18-18-01-879.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bb1c0676c6145d31
• Upwork Job ID: 1828505882730671209
• Last Price Increase: 2024-11-06
• Automatic offers:
• brunovjk | Reviewer | 103811978
• Krishna2323 | Contributor | 103811979

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@adelekennedy FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 2

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2023-10-03T14:17:00.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect - Tax code review step shows empty option when workspace does not have tax rate

What is the root cause of that problem?

• There is a major flaw in the dupe detection flow. We are always using the transactionID from the params and the transactionID remains the same transactionID on which we started the flow.
• We are using route.params.threadReportID on every dupe detection flow page.
• Due to the wrong transactionID the tax options are not shown because the policy which belong to the transaction doesn't contain tax and empty string is returned from PolicyUtils.getTaxByID(policy, taxID)?.name ?? ''
  

  App/src/pages/TransactionDuplicate/ReviewTaxCode.tsx

  Lines 23 to 25 in 9757ae2

  	const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${route.params.threadReportID}`);
  	const policy = PolicyUtils.getPolicy(report?.policyID ?? '');
  	const transactionID = TransactionUtils.getTransactionID(route.params.threadReportID ?? '');

  
  

  App/src/pages/TransactionDuplicate/ReviewTaxCode.tsx

  Lines 36 to 37 in 73f97c9

  	text: PolicyUtils.getTaxByID(policy, taxID)?.name ?? '',
  	value: taxID,

What changes do you think we should make in order to solve the problem?

• Instead of using route.params.threadReportID, we need to get the selected transactionID to get the transaction & report.
• We can get the selected transactionID from ONYXKEYS.REVIEW_DUPLICATES.

    const [reviewDuplicates] = useOnyx(ONYXKEYS.REVIEW_DUPLICATES);
    const transaction = TransactionUtils.getTransaction(reviewDuplicates?.transactionID ?? '');
    const [report] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`);

We can also check if the policy has any changed tax, category, tag etc or not. If the policy does not have any options except the none we can skip the step. The implementation needs to be done in MoneyRequestPreviewContent as well as useReviewDuplicatesNavigation. We would need to use selected transactionID to get the report and policy.

Here is test branch with very few changes for understanding the implementation.

What alternative solutions did you explore? (Optional)



Result

[github-actions]

Chirag-Shah Your proposal will be dismissed because you did not follow the proposal template.

[Krishna2323]

Proposal Updated

• Added alternative.

[melvin-bot]

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bb1c0676c6145d31