[HOLD for Payment 09-17][$250] Dupe detect - Incorrect receipt on confirmation page when expenses have different receipt

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to workspace chat.
Submit two same expenses (same amount and merchant) but with different receipts.
Go to transaction thread of the second expense.
Click Review duplicates.
Click Keep this one on the first expense.
Proceed to confirmation page.

Expected Result:

The confirmation page will show the receipt of the first expense because the first expense is selected in Step 6.

Actual Result:

The confirmation page shows the receipt of the second expense when the first expense is selected in Step 6.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6577537_1724191242282.Red_dot_not_displayed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01923b3933ce1dcc46
Upwork Job ID: 1828094692816105858
Last Price Increase: 2024-08-26
Automatic offers:

shubham1206agra | Reviewer | 103782432
nkdengineer | Contributor | 103782433

Issue Owner

Current Issue Owner: @mallenexpensify

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 2

@mallenexpensify

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-08-28 03:46:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detect - Incorrect receipt on confirmation page when expenses have different receipt

What is the root cause of that problem?

We are using the transactionID from originalMessage?.IOUTransactionID which will be the first transaction in the report.
When we are on confirmation page of review duplicates we need to use the transactionID of the selected duplicate.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 146 to 151 in 685bb4c

    
           const linkedTransactionID = useMemo(() => { 
        
               const originalMessage = parentReportAction && ReportActionsUtils.isMoneyRequestAction(parentReportAction) ? ReportActionsUtils.getOriginalMessage(parentReportAction) : undefined; 
        
               return originalMessage?.IOUTransactionID ?? '-1'; 
        
           }, [parentReportAction]); 
        
           const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${linkedTransactionID}`);

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 99 to 104 in 685bb4c

    
           <MoneyRequestView 
        
               report={report} 
        
               shouldShowAnimatedBackground={false} 
        
               readonly 
        
               updatedTransaction={transaction as OnyxEntry<Transaction>} 
        
           />

What changes do you think we should make in order to solve the problem?

When we have the updatedTransaction, we should be using updatedTransaction.transactionID instead of linkedTransactionID.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 151 in 685bb4c

    
           const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${linkedTransactionID}`);

const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${updatedTransaction?.transactionID ? updatedTransaction.transactionID : linkedTransactionID}`);

Same can be done for transactionBackup but I guess it's not needed.

Note: The reason we use conditions like updatedTransactionDescription ?? transactionDescription is that the updated details aren't included in the transaction. However, for other details like receipt, we can use the transaction object, and we can get the correct transaction using the solution mentioned above.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 541 in 685bb4c

title={updatedTransactionDescription ?? transactionDescription}

What alternative solutions did you explore? (Optional)  

Result

Monosnap.screencast.2024-08-21.14-41-04.mp4

Proposal

Please re-state the problem that we are trying to solve in this issue.

The confirmation page shows the receipt of the second expense when the first expense is selected in Step 6.

What is the root cause of that problem?

In this case, the linkedTransactionID is the transactionID of the second transaction because we're reviewing the duplicate in the transaction thread report of the second transaction.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 146 to 150 in 685bb4c

    
           const linkedTransactionID = useMemo(() => { 
        
               const originalMessage = parentReportAction && ReportActionsUtils.isMoneyRequestAction(parentReportAction) ? ReportActionsUtils.getOriginalMessage(parentReportAction) : undefined; 
        
               return originalMessage?.IOUTransactionID ?? '-1'; 
        
           }, [parentReportAction]);

Then we're getting the receipt URI from transaction data so the receipt of the second expense is displayed

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 295 to 300 in 685bb4c

    
           if (hasReceipt) { 
        
               receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction); 
        
           } 
        
           const pendingAction = transaction?.pendingAction; 
        
           const getPendingFieldAction = (fieldPath: TransactionPendingFieldsKey) => transaction?.pendingFields?.[fieldPath] ?? pendingAction;

What changes do you think we should make in order to solve the problem?

We should get the receipt URI data from updatedTransaction if it is not empty. Maybe we should update other places like here, here, here

if (hasReceipt) {
    receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(updatedTransaction ?? transaction);
}

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 295 to 297 in 685bb4c

    
           if (hasReceipt) { 
        
               receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction); 
        
           }

This solution is the same way as we do in other places like here

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 541 in 685bb4c

title={updatedTransactionDescription ?? transactionDescription}

What alternative solutions did you explore? (Optional)

Job added to Upwork: https://www.upwork.com/jobs/~01923b3933ce1dcc46

@shubham1206agra

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

@nkdengineer

@nkdengineer @shubham1206agra , can you confirm you two should be paid here? Once you do I'll take care of, ths

@mallenexpensify Yes, we need to be paid here

@nkdengineer

Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @shubham1206agra paid $250 via Upwork.

@shubham1206agra can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01923b3933ce1dcc46

@mallenexpensify

@mallenexpensify I accepted the offer

@shubham1206agra

@shubham1206agra paid, plz complete the BZ checklist.

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@] The PR that introduced the bug has been identified. Link to the PR:
[@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@] Determine if we should create a regression test for this bug.
[@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: Feat/dupe detection confirmation #42571
[@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42571/files#r1769457787
[@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not Required
[@shubham1206agra] Determine if we should create a regression test for this bug. No since confirmation page test should cover this also.
[@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@shubham1206agra

@shubham1206agra do we want a regression test for this? If not, why not? Thx

@shubham1206agra

@shubham1206agra do we want a regression test for this? If not, why not? Thx

No since confirmation page test should cover this also.

@shubham1206agra

Thanks @shubham1206agra , we should be all good here then!

Navigation Menu

Repository navigation

[HOLD for Payment 09-17][$250] Dupe detect - Incorrect receipt on confirmation page when expenses have different receipt #47774

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

29 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const linkedTransactionID = useMemo(() => {
	const originalMessage = parentReportAction && ReportActionsUtils.isMoneyRequestAction(parentReportAction) ? ReportActionsUtils.getOriginalMessage(parentReportAction) : undefined;
	return originalMessage?.IOUTransactionID ?? '-1';
	}, [parentReportAction]);

	const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${linkedTransactionID}`);

	<MoneyRequestView
	report={report}
	shouldShowAnimatedBackground={false}
	readonly
	updatedTransaction={transaction as OnyxEntry<Transaction>}
	/>

	if (hasReceipt) {
	receiptURIs = ReceiptUtils.getThumbnailAndImageURIs(transaction);
	}
	const pendingAction = transaction?.pendingAction;
	const getPendingFieldAction = (fieldPath: TransactionPendingFieldsKey) => transaction?.pendingFields?.[fieldPath] ?? pendingAction;

[HOLD for Payment 09-17][$250] Dupe detect - Incorrect receipt on confirmation page when expenses have different receipt #47774

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Aug 21, 2024

IuliiaHerets commented on Aug 21, 2024

IuliiaHerets commented on Aug 21, 2024

Krishna2323 commented on Aug 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Result

nkdengineer commented on Aug 21, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 26, 2024

melvin-bot commented on Aug 26, 2024

29 remaining items

shubham1206agra commented on Sep 18, 2024

mallenexpensify commented on Sep 19, 2024

shubham1206agra commented on Sep 20, 2024

mallenexpensify commented on Sep 20, 2024

shubham1206agra commented on Sep 21, 2024

mallenexpensify commented on Sep 23, 2024

shubham1206agra commented on Sep 24, 2024

mallenexpensify commented on Sep 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

What alternative solutions did you explore? (Optional)  