[HOLD for payment 2021-12-15] $500 Chat Switcher - Draft message from previous conv is displayed after using chat switcher

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~01e5dccfcff059ed0f

---

Action Performed:

Please, see this comment for further investigation and reproduction steps. Some of the hints might helps us find what is exactly going wrong.

1. Navigate to a conversation
2. Write something in compose box
3. Use ctrl+k command
4. Select another conversation

Expected Result:

Nothing should be displayed in compose box if the selected conversation didn't have a draft

Actual Result:

The draft from the previous conversation is displayed on the current conversation.

Workaround:

For chats with people which they have already chatted with, they can use the LHN chat switcher and the drafts are not transferred. Also when user sends a message to someone or composes a draft which is then deleted, they wont experience this bug for the given chat.

When this will prevail is in case user creates chat with new person using the Ctrl + k chat switcher.

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.0.86-2

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.206.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

---

From @iwiznia https://expensify.slack.com/archives/C01GTK53T8Q/p1629393716037000

BUG: (tested on web, staging, probably deploy blocker): draft is not working properly. Steps:
Write something in the chat but don't send it
Switch to another chat using CMD+K shortcut
See that draft message is carried over to the chat you switched, when it should not

[MelvinBot]

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

The only PR which might be related to this and could introduced it is #4538 @marcaaron but I am not completely sure. What do you think? I can't really dig into this one right now. I would in the morning if noone identifies what is causing it 🙇 Thank you in any case for having a look.

[luacmartins]

It seems that with #4538 ReportActionCompose no longer mounts and the input ref is lost in the update.

[marcaaron]

Why is the input not mounting? Which ref are you referring to?

[luacmartins]

When the chat is switch using the search bar didComponentMount is not triggered for ReportActionCompose and this inputRef does not seem to update.

[marcaaron]

The ReportActionCompose component should be mounting only once now. Is there some reason it needs to be unmounted and remounted? I'm not seeing it yet...

[luacmartins]

I agree that it should be mounted only once and we should keep it that way. What seems to be causing this issue is that this.setInputRef is not providing the correct ref to TextInputFocusable. Both this.props.comment and defaultValue are correct when switching chats with the Search Page, so I'm not sure why the value is not updated.