[$250] Workflows - App closes approval workflow RHP after upgrading from Additional approver page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.20-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: applausetester+kh050806@applause.expensifail.com
Email or phone of affected tester (no customers):
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a Collect workspace
3. Enable Workflows in More features
4. Go to Workflows
5. Enable Add approvals
6. Click on the "This default workspace applies.." modal
7. Click Additional approver
8. Click Upgrade
9. Click Got it, thanks

Expected Result:

App will redirect to Approval list after upgrading from Additional approver page

Actual Result:

App closes approval workflow RHP after upgrading from Additional approver page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6572271_1723659893734.20240815_022138.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0160cf6932aca1f586
• Upwork Job ID: 1825677034401864314
• Last Price Increase: 2024-08-19
• Automatic offers:
• DylanDylann | Reviewer | 103608330

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@francoisl FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[tgolen]

This feature is behind a beta so I am removing the feature flag cc @blazejkustra @DylanDylann

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App closes approval workflow RHP after upgrading from Additional approver page

What is the root cause of that problem?

If the user hasn't upgraded their workspace, the app doesn't navigate to the Upgrade Page when they click on the feature approval workflow. However, if the user clicks on "Add Approval Workflow" the app does navigate to the Upgrade Page

When clicking on "Add Approval Workflow," we already perform a check to see if the current policy is a control policy first.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 104 to 110 in 57ef25c

	const addApprovalAction = useCallback(() => {
	if (!PolicyUtils.isControlPolicy(policy)) {
	Navigation.navigate(
	ROUTES.WORKSPACE_UPGRADE.getRoute(route.params.policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID)),
	);
	return;
	}

However, when clicking on the approval workflow, we haven’t performed that check.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 180 to 184 in 57ef25c

	<ApprovalWorkflowSection
	approvalWorkflow={workflow}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_EDIT.getRoute(route.params.policyID, workflow.approvers[0].email))}
	/>
	</OfflineWithFeedback>

What changes do you think we should make in order to solve the problem?

We need to verify whether the current policy is a control policy before navigating to the edit approval workflow page.

App/src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx

Lines 180 to 184 in 57ef25c

	<ApprovalWorkflowSection
	approvalWorkflow={workflow}
	onPress={() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_EDIT.getRoute(route.params.policyID, workflow.approvers[0].email))}
	/>
	</OfflineWithFeedback>

if (!PolicyUtils.isControlPolicy(policy)) {
            Navigation.navigate(
                ROUTES.WORKSPACE_UPGRADE.getRoute(route.params.policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID)),
            );
            return;
}
Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_APPROVER.getRoute(route.params.policyID)

What alternative solutions did you explore? (Optional)