Repository navigation
[$500] Approve button not disappear after approving report offline if advanced approval set #47264
Description
Activity
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Triggered auto assignment to @marcaaron (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
We think this issue might be related to the #wave-control
Production
Recording.668.mp4
56 remaining items
PR is in progress
Deployed to prod today!
Reacted by Manan@adelekennedy this should be ready for payout. I couldn't exactly pinpoint the offending PR. Closest I think this should've been a part of https://github.com/Expensify/App/pull/44940/files.
Meanwhile I don't know if a regression test exists for the whole advance approval workflow. @adelekennedy can you confirm this? I think it should exists and in that case we don't need a regression test here.
Reacted by adelekennedyPayouts due:
- Contributor: $500 @FitseTLT (Upwork) @FitseTLT will you confirm you received the payment? I know we've been experiencing an Upwork bug, in this case i released payment first and then closed the contract
- Contributor+: $500 @mananjadhav (NewDot)
Upwork job is here.
@adelekennedy I received the payment Thx!
Reacted by adelekennedyis the issue still live?
📣 @AngadManroy! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details Your Expensify account email: <REPLACE EMAIL HERE> Upwork Profile Link: <REPLACE LINK HERE>$250 approved for @mananjadhav
@garrettmknight The amount is $500.
Reacted by adelekennedy
Metadata
Metadata
Labels
Type
Projects
- Status
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.19.2
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #44940
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition: create a control workspace, set "Manually approve all expenses" over to $10 and set advanced approval in OD:
Expected Result:
The approve button dsiappears
Actual Result:
The approve button is still displayed until user returns online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6570173_1723484236470.Recording__666.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @