[HOLD for payment 2024-11-07] [$250] NetSuite & Intacct Export - Missing integration icon next to export buttons

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Account has workspaces which are connected to QBO, NetSuite and Intacct

1. Go to staging.new.expensify.com
2. Go to workspace chat that is connected to QBO.
3. Submit an expense, and pay it.
4. Go to transaction thread.
5. Click on the export dropdown.
6. Note that there is QBO icon next to the buttons.
7. Click on the report header > Export.
8. Note that there is QBO icon next to the buttons.
9. Repeat Step 2 to 8 with workspaces that are connected to NetSuite and Intacct.

Expected Result:

For workspaces that are connected to NetSuite and Intacct, there will be icon next to "Export Online" and "Mark as manually entered" buttons.

Actual Result:

For workspaces that are connected to NetSuite and Intacct,

• in Step 6, there is no icon next to "Export Online" and "Mark as manually entered" buttons.
• in Step 8, it shows fallback avatar next to the buttons.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564546_1723041233397.20240807_222803.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011bdc1b4345ec12d6
• Upwork Job ID: 1821626241215848953
• Last Price Increase: 2024-08-08
• Automatic offers:
• akinwale | Reviewer | 103498918
• Krishna2323 | Contributor | 103498920
• neonbhai | Contributor | 103511682

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-07 15:47:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

NetSuite & Intacct Export - Missing integration icon next to export buttons

What is the root cause of that problem?

We already have the icon but we are not correctly using that.

App/src/components/ReportActionItem/ExportWithDropdownMenu.tsx

Line 55 in 0a33186

icon: iconToDisplay,

What changes do you think we should make in order to solve the problem?

Pass icons instead of icon like we do in ReportDetailsExportPage.

App/src/pages/home/report/ReportDetailsExportPage.tsx

Lines 71 to 76 in 0a33186

	icons: [
	{
	source: iconToDisplay ?? '',
	type: CONST.ICON_TYPE_AVATAR,
	},
	],

What alternative solutions did you explore? (Optional)

[neonbhai]

Edited by proposal-police: This proposal was edited at 2024-08-07 15:47:12 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

NetSuite & Intacct Export - Missing integration icon next to export buttons/

What is the root cause of that problem?

We are missing the icons from the codebase:

App/src/libs/ReportUtils.ts

Lines 7431 to 7439 in 0a33186

	function getIntegrationIcon(connectionName?: ConnectionName) {
	if (connectionName === CONST.POLICY.CONNECTIONS.NAME.XERO) {
	return XeroCircle;
	}
	if (connectionName === CONST.POLICY.CONNECTIONS.NAME.QBO) {
	return QBOCircle;
	}
	return undefined;
	}

What changes do you think we should make in order to solve the problem?

We will add the relevant icons here

The NetSuit and Intacct sags would be required from the design team.

[Krishna2323]

Proposal Updated

Updated RCA and solution.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011bdc1b4345ec12d6