Travel - Expensify Travel page opens with delay, "Something went wrong" error

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.17-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Issue found when executing PR: #46333

Action Performed:

1. Account B: Navigate to https://staging.new.expensify.com/
   in Chrome incognito
2. Account B: Log in with a new expensifail account
3. Account A: Navigate to https://staging.new.expensify.com/
   in Chrome
4. Account A: Log in with a new expensifail account
5. Account B: Create a workspace
6. Account B: Navigate to Account settings - Workspaces - Created workspace - Members
7. Account B: Click on "+ Invite member"
8. Account B: Invite account A
9. Account A: Navigate to FAB - Book travel
10. Account A: Click on the "Book travel" button
11. Account A: Type "123" into Address line 1 and choose any of the suggested addresses
12. Account A: Click on the "Save" button
13. Account A: Click on the "Book travel" button
14. Account A: Click insode the TOS checkbox
15. Account A: Click on the "Continue" button a few times until the Travel page opens

Expected Result:

Expensify Travel page should open instantly. The "Before we continue..." RHP should close in ND.

Actual Result:

Expensify Travel page opens with a delay of 3-4 seconds. "Something went wrong. Please try again later." error message appears above the "Continue" button after clicking it a few times.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6564343_1723032067955.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #vip-travel

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Travel page opens with delay, "Something went wrong" error

What is the root cause of that problem?

We don't disable the button and show loading indicator while waiting API response here

What changes do you think we should make in order to solve the problem?

Add isLoading?: boolean; here

Set isLoading to true on optimisticData here
Then set isLoading to false on successData and failureData

Pass isLoading on the button here

const [travelSetting] = useOnyx(ONYXKEYS.NVP_TRAVEL_SETTINGS);

...

isLoading={travelSetting?.isLoading}

What alternative solutions did you explore? (Optional)

[trjExpensify]

@shubham1206agra @rushatgabhane @stitesExpensify this deploy blocker was created when executing this PR: #46333