[CHECKLIST] [$250] Tasks - Task stays on the previously assigned user after assignee has been changed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.16
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): biruknew45+22s9sj@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to [staging.new.expensify.com]
2. Go to any chat
3. Click on the plus icon in the compose box
4. Select "Assign Task."
5. Give it a title, then click "Next."
6. Add an assignee, then confirm the task
7. Open the task
8. Click on the assignee and reassign it to another person
9. Open the task and reassign it to another person again

Expected Result:

When reassigning to the third person, the chat created when reassigning to the second person should be cleared or removed

Actual Result:

When reassigning to the third person, the chat created for the second person assigned still exists/persists, and they can see it and take some actions

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554782_1722094115952.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0116c365af04938c86
• Upwork Job ID: 1821259987888071161
• Last Price Increase: 2024-08-14
• Automatic offers:
• jjcoffee | Reviewer | 103541888
• dominictb | Contributor | 103541890

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[kpadmanabhan]

@lanitochka17 : unable to reproduce this in staging. is there a separate setting that should be enabled in account settings?
i do not see the PM chat popping up with assignee. see screenshot below.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task stays on the previously assigned user after assignee has been changed

What is the root cause of that problem?

Problem 1: OpenReport API call response still provide the reportAction_ onyxData for the task that no longer assigned to the user

Problem 2: canModifyTask here returns true for the user that no longer assigned to the task, so that user still can update the task and mark as completed. And gives an error when the previously assigned user marks the task as completed:

What changes do you think we should make in order to solve the problem?

Problem 1:
I think this is expected, the previously assigned user is still able to view the task and leave comments, although they are not assigned anymore. But if this needs to be fixed, it needs to be fixed on BE, and some optimistic data fix after the BE fix

Problem 2:
We need to return false on canModifyTask function here if the current user is not task owner and also not task assignee, so the previously assigned user cannot update the task and cannot mark the task as completed
Change this code to the following:

    if (sessionAccountID !== getTaskOwnerAccountID(taskReport) && sessionAccountID !== getTaskAssigneeAccountID(taskReport)) {
        return false;
    }

What alternative solutions did you explore? (Optional)

[melvin-bot]

@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0116c365af04938c86