[$250] iOS - Onboarding task deeplinks used within the app redirect users to the web

@JmillsExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.14
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #46082

Action Performed:

Open the iOS app
Create a new account (please use a public domain)
In the onboarding modal, select "manage my team's expenses"
Go to Expensify chat to view the task checklist
Open a task that contains a deeplink (e.g., meet your setup specialist or set up categories)
Open the desired task and tap on the hyperlink present within the steps (e.g., #admins room if meeting your setup specialist, or Workspaces if setting up categories)

Expected Result:

Onboarding task deeplinks used within the app should redirect users to the correct screen within the app

Actual Result:

Onboarding task deeplinks used within the app redirect users to the web

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6556810_1722294279029.QA-build-web-redirection-9.0.14.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01fe8e043da71e3915
Upwork Job ID: 1818998994406051154
Last Price Increase: 2024-08-22
Automatic offers:

nkdengineer | Contributor | 103652377

Issue Owner

Current Issue Owner: @JmillsExpensify

@arosiclair

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding task deeplinks used within the app redirect users to the web

What is the root cause of that problem?

The links on onboarding tasks created here

App/src/libs/actions/Report.ts

Lines 3272 to 3273 in e81223b

    
           adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '-1')}`, 
        
           workspaceLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

So if onboarding completed in production the links become https://new.expensify.com/...
if onboarding completed in staging the links become https://staging.new.expensify.com/...

If onboarding completed in production and link opened in staging we will encounter this issue

What changes do you think we should make in order to solve the problem?

Remove hasSameOrigin has origin from this condition

App/src/libs/actions/Link.ts

Line 145 in e81223b

if (internalNewExpensifyPath && hasSameOrigin) {

if (internalNewExpensifyPath) {

What alternative solutions did you explore? (Optional)

I reproduced on staging and not on production. It seems like there might be something wrong with our staging ENV for iOS since the link is generated in NewDot and it is using the prod URL. I'll try reproducing on Android to verify.

Not reproducible on Android staging v9.0.14.-3. I'm almost certain there's something going on with our staging .env

In these logs you can see we're sending Meet your setup specialist... text as a param with the prod link.

This hit prod 3 weeks ago so we should be good for payment and closing.

@nkdengineer

Payment summary:

Contributor: @nkdengineer $250
Reviewer: @abdulrahuman5196 $250

@abdulrahuman5196

@abdulrahuman5196 can you complete the BZ checklist please?

@JmillsExpensify

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Doesn't seem to be a regression.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Create a new account (please use a public domain)
In the onboarding modal, select "manage my team's expenses"
Go to Expensify chat to view the task checklist
Open a task that contains a deeplink (e.g., meet your setup specialist or set up categories)
Open the desired task and tap on the hyperlink present within the steps (e.g., #admins room if meeting your setup specialist, or Workspaces if setting up categories)
Onboarding task deeplinks used within the app should redirect users to the correct screen within the app

@JmillsExpensify Added the BZ checklist. Sorry for missing it previously.

@abdulrahuman5196

Confirming payment summary as follows:

$250 to @abdulrahuman5196 for the C+ review
$250 to @nkdengineer for the fix

@abdulrahuman5196

$250 approved for @abdulrahuman5196

All contributors paid and regression test created. Closing.

Navigation Menu

Repository navigation

[$250] iOS - Onboarding task deeplinks used within the app redirect users to the web #46495

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

70 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	adminsRoomLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.REPORT_WITH_ID.getRoute(adminsChatReportID ?? '-1')}`,
	workspaceLink: `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL}${ROUTES.WORKSPACE_INITIAL.getRoute(onboardingPolicyID ?? '-1')}`,

[$250] iOS - Onboarding task deeplinks used within the app redirect users to the web #46495

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Jul 30, 2024

github-actions commented on Jul 30, 2024

nyomanjyotisa commented on Jul 30, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

arosiclair commented on Jul 30, 2024

arosiclair commented on Jul 30, 2024

arosiclair commented on Jul 30, 2024

70 remaining items

arosiclair commented on Sep 24, 2024

JmillsExpensify commented on Sep 26, 2024

JmillsExpensify commented on Sep 26, 2024

abdulrahuman5196 commented on Sep 27, 2024

trjExpensify commented on Sep 30, 2024

JmillsExpensify commented on Sep 30, 2024

JmillsExpensify commented on Sep 30, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions