Repository navigation
[$250] Web - Email Mention Displays Number Instead of Email When Edited #46426
Description
Activity
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.- changed the title
[-]Web - Email Mention Displays Number Instead of Email When Edited[/-][+][$250] Web - Email Mention Displays Number Instead of Email When Edited[/+]on Jul 30, 2024 Job added to Upwork: https://www.upwork.com/jobs/~015d8db50900d91088
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)Proposal
Please re-state the problem that we are trying to solve in this issue.
When edit a mentioned user, the user name turns into account number.
What is the root cause of that problem?
In the following code
Line 18 in 881c548
the account id is saved into
accountIDToNameMapWhile editing a message, the parser in the following code
Line 34 in 881c548
would use
String(personalDetails.accountID)to parse the mentioned user.What changes do you think we should make in order to solve the problem?
use
accountIDToNameMap[personalDetails.accountID] = personalDetails.login ?? personalDetails.displayName;What alternative solutions did you explore? (Optional)
Add
loginattribute in the payload ofpersonalDetialsList
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): betlihemasfaw14@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
).
Expected Result:
The email should be displayed when attempting to edit the mentioned email
Actual Result:
When trying to edit the mentioned email, a number with the mention is displayed instead of the email
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6552541_1721904774758.Screen_Recording_2024-07-25_at_3.38.52_AM.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @DylanDylann