Repository navigation
[HOLD for payment 2024-08-23] [$500] Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN #46423
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tgolen
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1722266268926929
Action Performed:
- Open up the chat search
- Look for some group channels like #social
Expected Result:
The same chats that are showing bold in the LHN should be shown as bold in the chat search results
Actual Result:
Sometimes, chats will be bolded in the search results when they are not bolded in the LHN. This can happen for chats that you have muted (the search results will still show them as unread, while the LHN shows them as read).
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01803b7fcbf92fa7d7
- Upwork Job ID: 1818654097937596043
- Last Price Increase: 2024-07-31
Activity
melvin-bot commentedon Jul 29, 2024
Current assignee @tgolen is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.
melvin-bot commentedon Jul 29, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Jul 29, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
iwiznia commentedon Jul 29, 2024
We might be just removing the bolding there. Discussion here https://expensify.slack.com/archives/C03U7DCU4/p1722269953413229
[-]People you've never chatted with before showing as bold in the search results[/-][+]Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN[/+]tgolen commentedon Jul 31, 2024
In that thread, we had 8 👍 for removing the bold styling from the search options, so let's pursue that.
[-]Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN[/-][+][$250] Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN[/+]melvin-bot commentedon Jul 31, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01803b7fcbf92fa7d7
31 remaining items
tgolen commentedon Aug 22, 2024
Yeah, I think increasing the price is appropriate. @abekkala Could you please increase the price of this issue to $500?
[-][HOLD for payment 2024-08-23] [$250] Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN[/-][+][HOLD for payment 2024-08-23] [$500] Some chats are showing as bold (unread) in the chat search, but showing as non-bold (read) in the LHN[/+]melvin-bot commentedon Aug 22, 2024
abekkala commentedon Aug 22, 2024
UPDATED PAYMENT SUMMARY FOR AUG 23
abekkala commentedon Aug 23, 2024
@daledah payment sent and contract ended - thank you! 🎉
JmillsExpensify commentedon Aug 28, 2024
$500 approved for @s77rt
tgolen commentedon Oct 1, 2024
This is still happening for me. Notice my LHN in focus mode:
While the chat search has many bolded reports (I see about 30 as I scroll down):
s77rt commentedon Oct 2, 2024
@tgolen This is looking to be working as expected, chats that are bold/normal are consistent in the LHN and the find page.
tgolen commentedon Oct 2, 2024
How can you explain my screenshots then?
s77rt commentedon Oct 2, 2024
@tgolen Chats that are bold in screenshot1 are also bold in screenshot2 and vice-versa. If you are referring to the missing chats, that's a different bug.
tgolen commentedon Oct 2, 2024
OK, I see what you're saying. You're right, I'm specifically speaking about unread chats missing from my LHN. I can open a new issue for that.
s77rt commentedon Oct 2, 2024
@tgolen The chats not being listed is probably because their
notificationPreferenceis set tohidden. Maybe that's the expected behaviour?App/src/libs/SidebarUtils.ts
Lines 140 to 142 in 3b15d84
tgolen commentedon Oct 2, 2024
You could be right about that. I spot checked a few, and it looks like it matches your theory. So, in this case, I would say this makes for a pretty confusing UX for the user. I wonder if maybe we shouldn't be showing them as bold if you have
hiddenpreference. That would certainly have kept me from bringing this up at all.Maybe this is something we should discuss back in Slack to get consensus on?
cc @ZhenjaHorbach and @nkdengineer
s77rt commentedon Oct 5, 2024
Makes sense but let's ask in Slack to be sure