[HOLD for payment 2024-08-26][$250] Settings - Legal first and last name fields aren't accepting umlaut characters

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with any annyount
3. Navigate to Account settings - Legal name
4. Input "Ádám" as first name
5. Input "Horváth" as last name
6. Click on the "Save" button

Expected Result:

I should be able to save a legal name with umlauts

Actual Result:

Legal first and last name fields aren't accepting umlaut characters

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6554003_1722020390811.bandicam_2024-07-26_20-31-57-432.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015c756a4a661d9b30
• Upwork Job ID: 1818046683226587925
• Last Price Increase: 2024-08-05
• Automatic offers:
• situchan | Reviewer | 103451568

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Legal first and last name fields aren't accepting umlaut characters

What is the root cause of that problem?

In here We are considering a valid legal name that has no accented chars.

App/src/libs/ValidationUtils.ts

Lines 355 to 356 in 5e65276

	const hasAccentedChars = !!name.match(CONST.REGEX.ACCENT_LATIN_CHARS);
	return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name) && !hasAccentedChars;

What changes do you think we should make in order to solve the problem?

we should update regex ACCENT_LATIN_CHARS in here to exclude umlaut characters like Ádám Horváth

App/src/CONST.ts

Line 2292 in 5e65276

ACCENT_LATIN_CHARS: /[\u00C0-\u017F]/g,

What alternative solutions did you explore? (Optional)

We can consider removing the hasAccentedChars check condition because as far as I know there are many valid legal names that have accented chars

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015c756a4a661d9b30

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[situchan]

Looks like bank account personal name rejected accent chars in #37052 and then reverted in #44689 to accept back.
Similarly, should we now support accent chars in legal name?
cc: @johncschuster

[isogit123]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Legal first and last name fields aren't accepting umlaut characters

What is the root cause of that problem?

In the code below, the validation of the legal name requires that it has no accented characters.

App/src/libs/ValidationUtils.ts

Lines 355 to 356 in 5e65276

	const hasAccentedChars = !!name.match(CONST.REGEX.ACCENT_LATIN_CHARS);
	return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name) && !hasAccentedChars;

What changes do you think we should make in order to solve the problem?

To accept accented characters, remove the hasAccentedChars check from the code below so we take all Latin characters.

App/src/libs/ValidationUtils.ts

Lines 355 to 356 in 5e65276

	const hasAccentedChars = !!name.match(CONST.REGEX.ACCENT_LATIN_CHARS);
	return CONST.REGEX.ALPHABETIC_AND_LATIN_CHARS.test(name) && !hasAccentedChars;

After that, remove the ACCENT_LATIN_CHARS regex from the code below as it is no longer required.

App/src/CONST.ts

Line 2292 in 5e65276

ACCENT_LATIN_CHARS: /[\u00C0-\u017F]/g,

Below is a POC after applying the change:

acc.mp4

What alternative solutions did you explore? (Optional)