Repository navigation
[HOLD for payment 2024-08-09] [$250] "Leave" option icon should have "exit" icon instead of "thread" icon #46248
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1721922103779509
Action Performed:
- Go to workspace list
- Click 3 dot menu of the workspace where user is not an admin
Expected Result:
We should be using the exit icon for the "leave" option on workspaces
Actual Result:
Now it is a leave thread icon
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01df4ffa2e8434c8ce
- Upwork Job ID: 1816829296583393158
- Last Price Increase: 2024-07-26
Activity
melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.daledah commentedon Jul 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Now it is a leave thread icon
What is the root cause of that problem?
We are using ChatBubbles in:
App/src/pages/workspace/WorkspacesListPage.tsx
Line 174 in 0559307
What changes do you think we should make in order to solve the problem?
Should use Exit icon in this, what we used in leave room:
FitseTLT commentedon Jul 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Leave" option icon should have "exit" icon instead of "thread" icon
What is the root cause of that problem?
We are setting the
ChatBubblesicon hereApp/src/pages/workspace/WorkspacesListPage.tsx
Line 173 in b0f810d
What changes do you think we should make in order to solve the problem?
We should change it to
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Jul 26, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01df4ffa2e8434c8ce
[-]"Leave" option icon should have "exit" icon instead of "thread" icon[/-][+][$250] "Leave" option icon should have "exit" icon instead of "thread" icon[/+]melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)mollfpr commentedon Jul 26, 2024
The proposal from @daledah looks good to me!
🎀 👀 🎀 C+ reviewed!
melvin-bot commentedon Jul 26, 2024
Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
21 remaining items
anmurali commentedon Aug 14, 2024
@daledah - can you pls link me your Upwork profile?
daledah commentedon Aug 14, 2024
@anmurali Here it is https://www.upwork.com/freelancers/~0138d999529f34d33f
melvin-bot commentedon Aug 19, 2024
@francoisl, @anmurali, @mollfpr, @daledah Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Aug 21, 2024
@francoisl, @anmurali, @mollfpr, @daledah 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
mollfpr commentedon Aug 22, 2024
@anmurali Could you give the payment summary? Thank you!
melvin-bot commentedon Aug 23, 2024
@francoisl, @anmurali, @mollfpr, @daledah 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Aug 27, 2024
@francoisl, @anmurali, @mollfpr, @daledah 12 days overdue. Walking. Toward. The. Light...
anmurali commentedon Aug 28, 2024
Payment summary
daledah commentedon Aug 28, 2024
@anmurali Thanks, offer accepted
anmurali commentedon Aug 28, 2024
@mollfpr feel free to request via New Dot.
garrettmknight commentedon Aug 29, 2024
$250 approved for @mollfpr