Skip to content

[HOLD for payment 2024-08-09] [$250] Workspace - App back button overlaps with the status bar on not here page #46183

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Launch New Expensify app.
  2. Create a new workspace.
  3. Go to Workspace settings > More features > Report fields.
  4. Toggle on Report fields and tap Upgrade to upgrade to Control plan.
  5. Go to Troubleshoot > Clear cache and restart > Reset and refresh.
  6. Go to LHN and check that #admins room is present.
  7. Delete the workspace.
  8. Go to the now archieved #admins room.
  9. Tap on the "here" link.

Expected Result:

App back button will not overlap with the status bar on not here page.

Actual Result:

App back button overlaps with the status bar on not here page.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552399_1721897123593.ScreenRecording_07-25-2024_16-40-55_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014856468550d7e9c5
  • Upwork Job ID: 1816573450502248380
  • Last Price Increase: 2024-07-25
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jul 25, 2024
  2. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Jul 25, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Jul 25, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Jul 25, 2024

    @m-natarajan
    Author

    We think that this bug might be related to #wave-collect - Release 1

  6. removed
    DeployBlockerCashThis issue or pull request should block deployment
    DeployBlockerIndicates it should block deploying the API
    on Jul 25, 2024
  7. 28 remaining items

  8. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-08-09. 🎊

    For reference, here are some details about the assignees on this issue:

  9. melvin-bot commented on Aug 2, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  10. stephanieelliott commented on Aug 6, 2024

    @stephanieelliott
    Contributor

    Hey @bernhardoj @rushatgabhane seems like #46646 may be a regression -- can you take a look?

  11. rushatgabhane commented on Aug 6, 2024

    @rushatgabhane
    Member

    hey, it looks like it's unrelated to the PR

  12. stephanieelliott commented on Aug 7, 2024

    @stephanieelliott
    Contributor

    Got it! Ok thanks for checking.

  13. bernhardoj commented on Aug 9, 2024

    @bernhardoj
    Contributor

    Requested in ND for the payment today.

  14. JmillsExpensify commented on Aug 9, 2024

    @JmillsExpensify
    Contributor

    Can I get a payment summary?

  15. melvin-bot commented on Aug 9, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@stephanieelliott)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1816573450502248380/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. stephanieelliott commented on Aug 10, 2024

    @stephanieelliott
    Contributor

    Summarizing payment on this issue:

    Upwork job is here: https://www.upwork.com/jobs/~014856468550d7e9c5

  17. JmillsExpensify commented on Aug 10, 2024

    @JmillsExpensify
    Contributor

    $250 approved for each of @bernhardoj and @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions