Repository navigation
[HOLD for payment 2024-08-09] [$250] Workspace - App back button overlaps with the status bar on not here page #46183
Description
Activity
- addedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentDailyKSv2KSv2BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Jul 25, 2024 Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commented
on Jul 25, 2024 on Jul 25, 2024 – with GitHub ActionsContributorMore actions👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
We think that this bug might be related to #wave-collect - Release 1
- removedDeployBlockerCashThis issue or pull request should block deploymentThis issue or pull request should block deploymentDeployBlockerIndicates it should block deploying the APIIndicates it should block deploying the API
on Jul 25, 2024 28 remaining items
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-09. 🎊
For reference, here are some details about the assignees on this issue:
- @rushatgabhane requires payment through NewDot Manual Requests
- @bernhardoj requires payment through NewDot Manual Requests
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
- [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@rushatgabhane] Determine if we should create a regression test for this bug.
- [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Hey @bernhardoj @rushatgabhane seems like #46646 may be a regression -- can you take a look?
hey, it looks like it's unrelated to the PR
Got it! Ok thanks for checking.
Requested in ND for the payment today.
Can I get a payment summary?
Payment Summary
- Reviewer: @rushatgabhane owed $250 via NewDot
- Reviewer: @bernhardoj owed $250 via NewDot
BugZero Checklist (@stephanieelliott)
- I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
- I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1816573450502248380/hired)
- I have paid out the Upwork contracts or cancelled the ones that are incorrect
- I have verified the payment summary above is correct
Summarizing payment on this issue:
- Contributor: @bernhardoj $250 - please request via NewDot
- Contributor+: @rushatgabhane - $250 - please request via NewDot
Upwork job is here: https://www.upwork.com/jobs/~014856468550d7e9c5
- moved this from Polish to Done in [#whatsnext] #wave-collect
on Aug 10, 2024 $250 approved for each of @bernhardoj and @rushatgabhane
Metadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:
Action Performed:
Expected Result:
App back button will not overlap with the status bar on not here page.
Actual Result:
App back button overlaps with the status bar on not here page.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6552399_1721897123593.ScreenRecording_07-25-2024_16-40-55_1.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @stephanieelliott